Re: [PATCH][RFC] security: Convert LSM into a static interface

Chris Wright
2007-06-25T01:38:47Z

* James Morris (jmorris@namei.org) wrote:
> On Sun, 24 Jun 2007, Chris Wright wrote:
>
> > * James Morris (jmorris@namei.org) wrote:
> > > -module_param_named(disable, capability_disable, int, 0);
> > > -MODULE_PARM_DESC(disable, "To disable capabilities module set disable = 1");
> > > +
> > > +static int __init capability_disable_setup(char *str)
> > > +{
> > > + capability_disable = simple_strtol(str, NULL, 0);
> > > + return 1;
> > > +}
> > > +__setup("capability_disable=", capability_disable_setup);
> >
> > This changes the command line argument. Other than that and a some
> > sanity testing I'll take this.
>
> Do you mean the name change, or the logic?
>
> The name needs to change because kernel parameters are in a global
> namespace.

Sorry, I mean it's currently capability.disable (and the only reason it
matters is that at one point I know there were users of it).

thanks,
-chris