From: Patrick McHardy <kaber@trash.net>
To: Vasily Averin <vvs@sw.ru>
Cc: netfilter-devel@lists.netfilter.org, rusty@rustcorp.com.au,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eric Dumazet <dada1@cosmosbay.com>,
Jan Engelhardt <jengelh@computergmbh.de>,
"David S. Miller" <davem@davemloft.net>,
devel@openvz.org
Subject: Re: [NETFILTER] early_drop() imrovement (v4)
Date: Wed, 27 Jun 2007 15:28:39 +0200 [thread overview]
Message-ID: <46826607.4060201@trash.net> (raw)
In-Reply-To: <46826566.2060304@sw.ru>
Vasily Averin wrote:
> Patrick McHardy wrote:
>
>>+ for (i = 0; i < nf_conntrack_htable_size; i++) {
>>+ hlist_for_each_entry(h, n, &nf_conntrack_hash[hash], hnode) {
>>+ tmp = nf_ct_tuplehash_to_ctrack(h);
>>+ if (!test_bit(IPS_ASSURED_BIT, &tmp->status))
>>+ ct = tmp;
>
>
> It is incorrect: you should break nested loop here too.
No, as I said, we want the last entry of the chain.
prev parent reply other threads:[~2007-06-27 13:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 8:00 [PATCH 2.6.21-rc6] [netfilter] early_drop imrovement Vasily Averin
2007-04-06 8:24 ` Eric Dumazet
2007-04-06 10:26 ` Vasily Averin
2007-04-06 15:08 ` Patrick McHardy
2007-04-07 11:45 ` [PATCH nf-2.6.22] " Vasily Averin
2007-04-07 12:08 ` Eric Dumazet
2007-04-08 5:02 ` Vasily Averin
2007-05-09 6:59 ` [NETFILTER] early_drop() imrovement (v3) Vasily Averin
2007-06-25 13:53 ` Patrick McHardy
2007-06-25 14:36 ` Jan Engelhardt
2007-06-26 13:20 ` Vasily Averin
2007-06-26 13:27 ` Patrick McHardy
2007-06-27 8:46 ` [NETFILTER] early_drop() imrovement (v4) Vasily Averin
2007-06-27 8:52 ` Patrick McHardy
2007-06-27 12:04 ` Patrick McHardy
2007-06-27 12:29 ` Vasily Averin
2007-06-27 12:51 ` Patrick McHardy
2007-06-27 13:02 ` Vasily Averin
2007-06-27 13:18 ` Patrick McHardy
2007-06-27 13:25 ` Vasily Averin
2007-06-27 13:28 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46826607.4060201@trash.net \
--to=kaber@trash.net \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=rusty@rustcorp.com.au \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox