Re: [PATCH] Documentation/firmware_class/firmware_sample_driver.c

Satyam Sharma
2007-06-28T10:35:58Z

Hi,

[ It's good that you're trying to fix this, code in documentation should
be setting standards, clearly. ]

On 6/27/07, Anders Blomdell <anders.blomdell@control.lth.se> wrote:
> [...]
> Minor modifications to make the example load and unload without Oops
> [...]
> static int sample_init(void)
> {
> - device_initialize(&ghost_device);
> + device_register(&ghost_device);
> /* since there is no real hardware insertion I just call the
> * sample probe functions here */
> - sample_probe_specific();
> + /* sample_probe_specific(); */
> sample_probe_default();
> - sample_probe_async();
> + /*sample_probe_async();*/
> return 0;
> }

But IMO the above functions should be *fixed* to work properly instead
of simply commenting them out. If they are un-fixable, why even keep
the broken code in that file (only to mislead readers in future?). You
might as well remove those calls (and the function definitions) completely.
Best would be to fix them, of course.

My Rs. 0.02,
Satyam