From: Chuck Ebbert <cebbert@redhat.com>
To: Andi Kleen <ak@suse.de>
Cc: Loic Prylli <loic@myri.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MTRR: Fix race causing set_mtrr to go into infinite loop
Date: Thu, 28 Jun 2007 15:52:21 -0400 [thread overview]
Message-ID: <46841175.8070901@redhat.com> (raw)
In-Reply-To: <200706260034.41940.ak@suse.de>
On 06/25/2007 06:34 PM, Andi Kleen wrote:
> On Tuesday 26 June 2007 00:05:17 Chuck Ebbert wrote:
>> On 06/25/2007 05:38 PM, Loic Prylli wrote:
>>
>> [cc: Andi]
>>
>>> Processors synchronization in set_mtrr requires the .gate field
>>> to be set after .count field is properly initialized. Without an explicit
>>> barrier, the compiler was reordering those memory stores. That was sometimes
>>> causing a processor (in ipi_handler) to see the .gate change and
>>> decrement .count before the latter is set by set_mtrr() (which
>>> then hangs in a infinite loop with irqs disabled).
>
> Hmm, perhaps we should just put the smp_wmb into atomic_set().
> Near all other atomic operations have memory barriers too. I think
> that would be the better fix.
Can we get something merged before 2.6.22-final?
The original patch seems okay...
prev parent reply other threads:[~2007-06-28 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 21:38 [PATCH] MTRR: Fix race causing set_mtrr to go into infinite loop Loic Prylli
2007-06-25 22:05 ` Chuck Ebbert
2007-06-25 22:34 ` Andi Kleen
2007-06-26 1:40 ` Loic Prylli
2007-06-28 19:52 ` Chuck Ebbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46841175.8070901@redhat.com \
--to=cebbert@redhat.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=loic@myri.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox