From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758997AbXGBDMp (ORCPT ); Sun, 1 Jul 2007 23:12:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756897AbXGBDMg (ORCPT ); Sun, 1 Jul 2007 23:12:36 -0400 Received: from host06.hostingexpert.com ([216.80.70.60]:48091 "EHLO host06.hostingexpert.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756845AbXGBDMf (ORCPT ); Sun, 1 Jul 2007 23:12:35 -0400 X-Greylist: delayed 20579 seconds by postgrey-1.27 at vger.kernel.org; Sun, 01 Jul 2007 23:12:35 EDT Message-ID: <46881CBB.4020000@linuxtv.org> Date: Sun, 01 Jul 2007 17:29:31 -0400 From: Michael Krufky User-Agent: Thunderbird 1.5.0.12 (X11/20070604) MIME-Version: 1.0 To: Adrian Bunk CC: Andrew Morton , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Subject: Re: 2.6.22-rc6-mm1: TUNER_TEA5761 kconfig fixes References: <20070628034321.38c9f12b.akpm@linux-foundation.org> <20070701202320.GS10869@stusta.de> In-Reply-To: <20070701202320.GS10869@stusta.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host06.hostingexpert.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - linuxtv.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Adrian Bunk wrote: > On Thu, Jun 28, 2007 at 03:43:21AM -0700, Andrew Morton wrote: > >> ... >> Changes since 2.6.22-rc4-mm2: >> ... >> git-dvb.patch >> ... >> git trees >> ... >> > > > The following doesn't make much sense: > > drivers/media/video/Kconfig: > ... > config TUNER_TEA5761 > tristate "TEA 5761 radio tuner (EXPERIMENTAL)" > ... > > drivers/media/video/Makefile: > ... > ifneq ($(CONFIG_TUNER_TEA5761),) > tuner-objs += tea5761.o > endif > ... > > With this setup, TUNER_TEA5761=m is equivalent to TUNER_TEA5761=y. > > This patch therefore changes TUNER_TEA5761 to a bool. > > The missing dependency on EXPERIMENTAL the prompt text indicates also > gets added by this patch. > > Additionally, the Makefile entry can now be written in a more compact way. > > Signed-off-by: Adrian Bunk > Acked-by: Michael Krufky Thanks, Adrian Mauro, I'll push this into hg and send you a pull request. > --- > > BTW: tea5761.c is currently completely unused. > > drivers/media/video/Kconfig | 3 ++- > drivers/media/video/Makefile | 4 +--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > --- linux-2.6.22-rc6-mm1/drivers/media/video/Kconfig.old 2007-06-30 03:51:13.000000000 +0200 > +++ linux-2.6.22-rc6-mm1/drivers/media/video/Kconfig 2007-06-30 03:51:40.000000000 +0200 > @@ -490,7 +490,8 @@ > If in doubt, say N. > > config TUNER_TEA5761 > - tristate "TEA 5761 radio tuner (EXPERIMENTAL)" > + bool "TEA 5761 radio tuner (EXPERIMENTAL)" > + depends on EXPERIMENTAL > depends on I2C > select VIDEO_TUNER > help > --- linux-2.6.22-rc6-mm1/drivers/media/video/Makefile.old 2007-06-30 03:52:00.000000000 +0200 > +++ linux-2.6.22-rc6-mm1/drivers/media/video/Makefile 2007-06-30 03:53:25.000000000 +0200 > @@ -7,9 +7,7 @@ > tuner-objs := tuner-core.o tuner-types.o tuner-simple.o \ > mt20xx.o tda8290.o tea5767.o tda9887.o > > -ifneq ($(CONFIG_TUNER_TEA5761),) > - tuner-objs += tea5761.o > -endif > +tuner-$(CONFIG_TUNER_TEA5761) += tea5761.o > > msp3400-objs := msp3400-driver.o msp3400-kthreads.o > >