From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759881AbXGBOPI (ORCPT ); Mon, 2 Jul 2007 10:15:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752431AbXGBOOz (ORCPT ); Mon, 2 Jul 2007 10:14:55 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:51892 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753370AbXGBOOx (ORCPT ); Mon, 2 Jul 2007 10:14:53 -0400 Message-ID: <4689085A.9030005@garzik.org> Date: Mon, 02 Jul 2007 10:14:50 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Robert Hancock CC: linux-kernel , ide , Andrew Morton , Roy Franz Subject: Re: [PATCH -mm] sata_nv: allow changing queue depth References: <468457C8.7060507@shaw.ca> In-Reply-To: <468457C8.7060507@shaw.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Robert Hancock wrote: > The sata_nv driver was missing the change_queue_depth hook in the SCSI host > template which the other NCQ-capable libata drivers had. This made it impossible > to change the queue depth by user request. Add this in. > > Signed-off-by: Robert Hancock > > --- linux-2.6.22-rc6-mm1/drivers/ata/sata_nv.c 2007-06-28 17:30:28.000000000 -0600 > +++ linux-2.6.22-rc6-mm1edit/drivers/ata/sata_nv.c 2007-06-28 17:39:30.000000000 -0600 > @@ -398,6 +398,7 @@ static struct scsi_host_template nv_adma > .name = DRV_NAME, > .ioctl = ata_scsi_ioctl, > .queuecommand = ata_scsi_queuecmd, > + .change_queue_depth = ata_scsi_change_queue_depth, > .can_queue = NV_ADMA_MAX_CPBS, > .this_id = ATA_SHT_THIS_ID, > .sg_tablesize = NV_ADMA_SGTBL_TOTAL_LEN, > @@ -416,6 +417,7 @@ static struct scsi_host_template nv_swnc > .name = DRV_NAME, > .ioctl = ata_scsi_ioctl, > .queuecommand = ata_scsi_queuecmd, > + .change_queue_depth = ata_scsi_change_queue_depth, > .can_queue = ATA_MAX_QUEUE, > .this_id = ATA_SHT_THIS_ID, > .sg_tablesize = LIBATA_MAX_PRD, applied manually, patch didn't apply to 2.6.22-rc7