From: Andy Whitcroft <andyw@uk.ibm.com>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Trilok Soni <soni.trilok@gmail.com>,
Andy Whitcroft <APW@uk.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: checkpatch: need space before that '*' (ctx:BxB)
Date: Tue, 03 Jul 2007 16:19:40 +0100 [thread overview]
Message-ID: <468A690C.4010401@uk.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0706271448430.11120@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Jun 27 2007 17:24, Trilok Soni wrote:
>> In the following case we may not need space before that "(*)". It
>> looks like false positive. Please check.
>>
>> need space before that '*' (ctx:BxB)
>> #1034: FILE: drivers/video/omap/omapfb.c:968:
>> + omapfb_nb->nb.notifier_call = (int (*)(struct notifier_block *,
>> ^
>
> The line, as presented in your mail, is already correct
> Keep the space between "int" and "(*)" :-)
> [follows how you'd declare a normal variable]
>
>
> Jan
Yep this was a falsie. This was fixed in the recent 0.06 release.
-apw
prev parent reply other threads:[~2007-07-03 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-27 11:54 checkpatch: need space before that '*' (ctx:BxB) Trilok Soni
2007-06-27 12:49 ` Jan Engelhardt
2007-07-03 15:19 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468A690C.4010401@uk.ibm.com \
--to=andyw@uk.ibm.com \
--cc=APW@uk.ibm.com \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=soni.trilok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox