* checkpatch: need space before that '*' (ctx:BxB)
@ 2007-06-27 11:54 Trilok Soni
2007-06-27 12:49 ` Jan Engelhardt
0 siblings, 1 reply; 3+ messages in thread
From: Trilok Soni @ 2007-06-27 11:54 UTC (permalink / raw)
To: apw; +Cc: linux-kernel
Andy,
In the following case we may not need space before that "(*)". It
looks like false positive. Please check.
need space before that '*' (ctx:BxB)
#1034: FILE: drivers/video/omap/omapfb.c:968:
+ omapfb_nb->nb.notifier_call = (int (*)(struct notifier_block *,
^
--
--Trilok Soni
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: checkpatch: need space before that '*' (ctx:BxB)
2007-06-27 11:54 checkpatch: need space before that '*' (ctx:BxB) Trilok Soni
@ 2007-06-27 12:49 ` Jan Engelhardt
2007-07-03 15:19 ` Andy Whitcroft
0 siblings, 1 reply; 3+ messages in thread
From: Jan Engelhardt @ 2007-06-27 12:49 UTC (permalink / raw)
To: Trilok Soni; +Cc: apw, linux-kernel
On Jun 27 2007 17:24, Trilok Soni wrote:
>
> In the following case we may not need space before that "(*)". It
> looks like false positive. Please check.
>
> need space before that '*' (ctx:BxB)
> #1034: FILE: drivers/video/omap/omapfb.c:968:
> + omapfb_nb->nb.notifier_call = (int (*)(struct notifier_block *,
> ^
The line, as presented in your mail, is already correct
Keep the space between "int" and "(*)" :-)
[follows how you'd declare a normal variable]
Jan
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: checkpatch: need space before that '*' (ctx:BxB)
2007-06-27 12:49 ` Jan Engelhardt
@ 2007-07-03 15:19 ` Andy Whitcroft
0 siblings, 0 replies; 3+ messages in thread
From: Andy Whitcroft @ 2007-07-03 15:19 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: Trilok Soni, Andy Whitcroft, linux-kernel
Jan Engelhardt wrote:
> On Jun 27 2007 17:24, Trilok Soni wrote:
>> In the following case we may not need space before that "(*)". It
>> looks like false positive. Please check.
>>
>> need space before that '*' (ctx:BxB)
>> #1034: FILE: drivers/video/omap/omapfb.c:968:
>> + omapfb_nb->nb.notifier_call = (int (*)(struct notifier_block *,
>> ^
>
> The line, as presented in your mail, is already correct
> Keep the space between "int" and "(*)" :-)
> [follows how you'd declare a normal variable]
>
>
> Jan
Yep this was a falsie. This was fixed in the recent 0.06 release.
-apw
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-03 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-27 11:54 checkpatch: need space before that '*' (ctx:BxB) Trilok Soni
2007-06-27 12:49 ` Jan Engelhardt
2007-07-03 15:19 ` Andy Whitcroft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox