From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762055AbXGFABH (ORCPT ); Thu, 5 Jul 2007 20:01:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753702AbXGFAAx (ORCPT ); Thu, 5 Jul 2007 20:00:53 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:52108 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752567AbXGFAAw (ORCPT ); Thu, 5 Jul 2007 20:00:52 -0400 Message-ID: <468D862F.2030604@garzik.org> Date: Thu, 05 Jul 2007 20:00:47 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Andrew Morton CC: Kristen Carlson Accardi , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, James.Bottomley@steeleye.com, edwintorok@gmail.com, axboe@kernel.dk, linux-scsi@vger.kernel.org Subject: Re: [patch 3/4] Enable link power management for ata drivers References: <20070705194909.337398431@intel.com> <20070705130530.5873afeb.kristen.c.accardi@intel.com> <20070705153334.08402809.akpm@linux-foundation.org> In-Reply-To: <20070705153334.08402809.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > On Thu, 5 Jul 2007 13:05:30 -0700 > Kristen Carlson Accardi wrote: > >> + ATA_DFLAG_IPM = (1 << 6), /* device supports interface PM */ >> ATA_DFLAG_CFG_MASK = (1 << 8) - 1, > > I had to bump this to (1<<7), so we've run out. You can shuffle the numbers a bit, as long as the masks (*_MASK) stay correct for their purpose Jeff