Re: [PATCH 1/3] GEODE: basic infrastructure support for AMD geode-class machines

Andy Whitcroft
2007-07-06T13:55:41Z

Andrew Morton wrote:
> The patches have some trivial-but-common coding-style bloopers which
> scripts/checkpatch.pl will detect. Please check it out.
> oh

> Please send a patch which documents mfgpt_irq in
> Documentation/kernel-parameters.txt, thanks.
>
> Andy, the miss rate on documentation for new __setup() handlers is about
> 75%. Might be worth adding to checkpatch.pl.

If we are willing to expect the update in the same patch then we can
emit a failure if the presented string in __check isn't in the update to
the documentation. I guess emit it as a CHECK in case they have loads
of them and a separate documentation patch.

CHECK: __setup appears un-documented -- check
Documentation/kernel-parameters.txt
#131: FILE: arch/i386/kernel/mfgpt.c:233:
+__setup("mfgpt_irq=", mfgpt_setup);

-apw