maps2-move-the-page-walker-code-to-lib.patch

maps2-move-the-page-walker-code-to-lib.patch

[Rusty Russell]

Matt wrote:
> This lets it get shared outside of proc/ and linked in only when needed.

Erk, this really belongs in the mm dir.  You can use "lib-y +=
pagewalk.o" there, and it seems to work as well as doing it in lib.

Cheers,
Rusty.

Re: maps2-move-the-page-walker-code-to-lib.patch

[Nick Piggin]

Rusty Russell wrote:
> Matt wrote:
> 
>>This lets it get shared outside of proc/ and linked in only when needed.
> 
> 
> Erk, this really belongs in the mm dir.  You can use "lib-y +=
> pagewalk.o" there, and it seems to work as well as doing it in lib.

+1 from me, again :)

-- 
SUSE Labs, Novell Inc.

Re: maps2-move-the-page-walker-code-to-lib.patch

[Matt Mackall]

On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote:
> Matt wrote:
> > This lets it get shared outside of proc/ and linked in only when needed.
> 
> Erk, this really belongs in the mm dir.  You can use "lib-y +=
> pagewalk.o" there, and it seems to work as well as doing it in lib.

Are you sure? I tested that a few months ago and it didn't work for
me. I seem to recall it wanted a chunk of makefile surgery.

-- 
Mathematics is the supreme nostalgia of our time.

Re: maps2-move-the-page-walker-code-to-lib.patch

[Rusty Russell]

On Mon, 2007-07-09 at 15:22 -0500, Matt Mackall wrote:
> On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote:
> > Matt wrote:
> > > This lets it get shared outside of proc/ and linked in only when needed.
> > 
> > Erk, this really belongs in the mm dir.  You can use "lib-y +=
> > pagewalk.o" there, and it seems to work as well as doing it in lib.
> 
> Are you sure? I tested that a few months ago and it didn't work for
> me. I seem to recall it wanted a chunk of makefile surgery.

Well, I tested here and it worked unless I screwed something (producing
lib.a in mm/ and linking it in).  And when I turned off all the CONFIG
options which required it, the symbols disappeared from the vmlinux...

Rusty.

Re: maps2-move-the-page-walker-code-to-lib.patch

[Sam Ravnborg]

On Tue, Jul 10, 2007 at 12:06:35PM +1000, Rusty Russell wrote:
> On Mon, 2007-07-09 at 15:22 -0500, Matt Mackall wrote:
> > On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote:
> > > Matt wrote:
> > > > This lets it get shared outside of proc/ and linked in only when needed.
> > > 
> > > Erk, this really belongs in the mm dir.  You can use "lib-y +=
> > > pagewalk.o" there, and it seems to work as well as doing it in lib.
> > 
> > Are you sure? I tested that a few months ago and it didn't work for
> > me. I seem to recall it wanted a chunk of makefile surgery.
> 
> Well, I tested here and it worked unless I screwed something (producing
> lib.a in mm/ and linking it in).  And when I turned off all the CONFIG
> options which required it, the symbols disappeared from the vmlinux...

I think you had some additional change somewhere...
kbuild will only look for lib.a files (produced from all files
listed with lib-y _except_ files listed with obj-y too).

kbuild by default know about lib/ but almost all archs
add the directory: arch/$(ARCH)/lib but no-one
add mm/.
See assignment to libs-y.

Add see the bad documentation in Documentation/kbuild/makefiles.txt

	Sam

Re: maps2-move-the-page-walker-code-to-lib.patch

[Rusty Russell]

On Fri, 2007-07-13 at 22:48 +0200, Sam Ravnborg wrote:
> On Tue, Jul 10, 2007 at 12:06:35PM +1000, Rusty Russell wrote:
> > On Mon, 2007-07-09 at 15:22 -0500, Matt Mackall wrote:
> > > On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote:
> > > > Matt wrote:
> > > > > This lets it get shared outside of proc/ and linked in only when needed.
> > > > 
> > > > Erk, this really belongs in the mm dir.  You can use "lib-y +=
> > > > pagewalk.o" there, and it seems to work as well as doing it in lib.
> > > 
> > > Are you sure? I tested that a few months ago and it didn't work for
> > > me. I seem to recall it wanted a chunk of makefile surgery.
> > 
> > Well, I tested here and it worked unless I screwed something (producing
> > lib.a in mm/ and linking it in).  And when I turned off all the CONFIG
> > options which required it, the symbols disappeared from the vmlinux...
> 
> I think you had some additional change somewhere...
> kbuild will only look for lib.a files (produced from all files
> listed with lib-y _except_ files listed with obj-y too).

You're right: mm/lib.a gets built, but not linked in.  Sorry for the
false report...

Rusty.