* maps2-move-the-page-walker-code-to-lib.patch
@ 2007-07-08 5:49 Rusty Russell
2007-07-08 9:46 ` maps2-move-the-page-walker-code-to-lib.patch Nick Piggin
2007-07-09 20:22 ` maps2-move-the-page-walker-code-to-lib.patch Matt Mackall
0 siblings, 2 replies; 6+ messages in thread
From: Rusty Russell @ 2007-07-08 5:49 UTC (permalink / raw)
To: Matt Mackall
Cc: Jeremy Fitzhardinge, David Rientjes, Andrew Morton,
lkml - Kernel Mailing List, Sam Ravnborg
Matt wrote:
> This lets it get shared outside of proc/ and linked in only when needed.
Erk, this really belongs in the mm dir. You can use "lib-y +=
pagewalk.o" there, and it seems to work as well as doing it in lib.
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: maps2-move-the-page-walker-code-to-lib.patch 2007-07-08 5:49 maps2-move-the-page-walker-code-to-lib.patch Rusty Russell @ 2007-07-08 9:46 ` Nick Piggin 2007-07-09 20:22 ` maps2-move-the-page-walker-code-to-lib.patch Matt Mackall 1 sibling, 0 replies; 6+ messages in thread From: Nick Piggin @ 2007-07-08 9:46 UTC (permalink / raw) To: Rusty Russell Cc: Matt Mackall, Jeremy Fitzhardinge, David Rientjes, Andrew Morton, lkml - Kernel Mailing List, Sam Ravnborg Rusty Russell wrote: > Matt wrote: > >>This lets it get shared outside of proc/ and linked in only when needed. > > > Erk, this really belongs in the mm dir. You can use "lib-y += > pagewalk.o" there, and it seems to work as well as doing it in lib. +1 from me, again :) -- SUSE Labs, Novell Inc. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: maps2-move-the-page-walker-code-to-lib.patch 2007-07-08 5:49 maps2-move-the-page-walker-code-to-lib.patch Rusty Russell 2007-07-08 9:46 ` maps2-move-the-page-walker-code-to-lib.patch Nick Piggin @ 2007-07-09 20:22 ` Matt Mackall 2007-07-10 2:06 ` maps2-move-the-page-walker-code-to-lib.patch Rusty Russell 1 sibling, 1 reply; 6+ messages in thread From: Matt Mackall @ 2007-07-09 20:22 UTC (permalink / raw) To: Rusty Russell Cc: Jeremy Fitzhardinge, David Rientjes, Andrew Morton, lkml - Kernel Mailing List, Sam Ravnborg On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote: > Matt wrote: > > This lets it get shared outside of proc/ and linked in only when needed. > > Erk, this really belongs in the mm dir. You can use "lib-y += > pagewalk.o" there, and it seems to work as well as doing it in lib. Are you sure? I tested that a few months ago and it didn't work for me. I seem to recall it wanted a chunk of makefile surgery. -- Mathematics is the supreme nostalgia of our time. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: maps2-move-the-page-walker-code-to-lib.patch 2007-07-09 20:22 ` maps2-move-the-page-walker-code-to-lib.patch Matt Mackall @ 2007-07-10 2:06 ` Rusty Russell 2007-07-13 20:48 ` maps2-move-the-page-walker-code-to-lib.patch Sam Ravnborg 0 siblings, 1 reply; 6+ messages in thread From: Rusty Russell @ 2007-07-10 2:06 UTC (permalink / raw) To: Matt Mackall Cc: Jeremy Fitzhardinge, David Rientjes, Andrew Morton, lkml - Kernel Mailing List, Sam Ravnborg On Mon, 2007-07-09 at 15:22 -0500, Matt Mackall wrote: > On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote: > > Matt wrote: > > > This lets it get shared outside of proc/ and linked in only when needed. > > > > Erk, this really belongs in the mm dir. You can use "lib-y += > > pagewalk.o" there, and it seems to work as well as doing it in lib. > > Are you sure? I tested that a few months ago and it didn't work for > me. I seem to recall it wanted a chunk of makefile surgery. Well, I tested here and it worked unless I screwed something (producing lib.a in mm/ and linking it in). And when I turned off all the CONFIG options which required it, the symbols disappeared from the vmlinux... Rusty. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: maps2-move-the-page-walker-code-to-lib.patch 2007-07-10 2:06 ` maps2-move-the-page-walker-code-to-lib.patch Rusty Russell @ 2007-07-13 20:48 ` Sam Ravnborg 2007-07-17 1:09 ` maps2-move-the-page-walker-code-to-lib.patch Rusty Russell 0 siblings, 1 reply; 6+ messages in thread From: Sam Ravnborg @ 2007-07-13 20:48 UTC (permalink / raw) To: Rusty Russell Cc: Matt Mackall, Jeremy Fitzhardinge, David Rientjes, Andrew Morton, lkml - Kernel Mailing List On Tue, Jul 10, 2007 at 12:06:35PM +1000, Rusty Russell wrote: > On Mon, 2007-07-09 at 15:22 -0500, Matt Mackall wrote: > > On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote: > > > Matt wrote: > > > > This lets it get shared outside of proc/ and linked in only when needed. > > > > > > Erk, this really belongs in the mm dir. You can use "lib-y += > > > pagewalk.o" there, and it seems to work as well as doing it in lib. > > > > Are you sure? I tested that a few months ago and it didn't work for > > me. I seem to recall it wanted a chunk of makefile surgery. > > Well, I tested here and it worked unless I screwed something (producing > lib.a in mm/ and linking it in). And when I turned off all the CONFIG > options which required it, the symbols disappeared from the vmlinux... I think you had some additional change somewhere... kbuild will only look for lib.a files (produced from all files listed with lib-y _except_ files listed with obj-y too). kbuild by default know about lib/ but almost all archs add the directory: arch/$(ARCH)/lib but no-one add mm/. See assignment to libs-y. Add see the bad documentation in Documentation/kbuild/makefiles.txt Sam ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: maps2-move-the-page-walker-code-to-lib.patch 2007-07-13 20:48 ` maps2-move-the-page-walker-code-to-lib.patch Sam Ravnborg @ 2007-07-17 1:09 ` Rusty Russell 0 siblings, 0 replies; 6+ messages in thread From: Rusty Russell @ 2007-07-17 1:09 UTC (permalink / raw) To: Sam Ravnborg Cc: Matt Mackall, Jeremy Fitzhardinge, David Rientjes, Andrew Morton, lkml - Kernel Mailing List On Fri, 2007-07-13 at 22:48 +0200, Sam Ravnborg wrote: > On Tue, Jul 10, 2007 at 12:06:35PM +1000, Rusty Russell wrote: > > On Mon, 2007-07-09 at 15:22 -0500, Matt Mackall wrote: > > > On Sun, Jul 08, 2007 at 03:49:56PM +1000, Rusty Russell wrote: > > > > Matt wrote: > > > > > This lets it get shared outside of proc/ and linked in only when needed. > > > > > > > > Erk, this really belongs in the mm dir. You can use "lib-y += > > > > pagewalk.o" there, and it seems to work as well as doing it in lib. > > > > > > Are you sure? I tested that a few months ago and it didn't work for > > > me. I seem to recall it wanted a chunk of makefile surgery. > > > > Well, I tested here and it worked unless I screwed something (producing > > lib.a in mm/ and linking it in). And when I turned off all the CONFIG > > options which required it, the symbols disappeared from the vmlinux... > > I think you had some additional change somewhere... > kbuild will only look for lib.a files (produced from all files > listed with lib-y _except_ files listed with obj-y too). You're right: mm/lib.a gets built, but not linked in. Sorry for the false report... Rusty. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-07-17 1:10 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-07-08 5:49 maps2-move-the-page-walker-code-to-lib.patch Rusty Russell 2007-07-08 9:46 ` maps2-move-the-page-walker-code-to-lib.patch Nick Piggin 2007-07-09 20:22 ` maps2-move-the-page-walker-code-to-lib.patch Matt Mackall 2007-07-10 2:06 ` maps2-move-the-page-walker-code-to-lib.patch Rusty Russell 2007-07-13 20:48 ` maps2-move-the-page-walker-code-to-lib.patch Sam Ravnborg 2007-07-17 1:09 ` maps2-move-the-page-walker-code-to-lib.patch Rusty Russell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox