Re: Please revert 21564fd2a3deb48200b595332f9ed4c9f311f2a7

Andi Kleen
2007-07-09T10:35:39Z

On Monday 09 July 2007 12:06:05 Alan Cox wrote:
> On Mon, 9 Jul 2007 11:39:25 +0200
> Andi Kleen <ak@suse.de> wrote:
>
> >
> > > > It will be solved differently longer term, but short term the fix
> > > > was still needed. There are limits on what can be done late
> > > > in the release cycle so simple patches win.
> > >
> > > Your patch got into Linus' tree in the middle of the merge window...
> >
> > Even in the middle of the merge window it might be too late
> > to do some large scale restructuring (as would have been needed
> > for this particular issue)
>
> You should have reverted the change and held it over for 2.6.23-rc1 then
> as other developers do with problem code.

Didn't seem justified.

If someone really wanted to do evil binary only virtualization there
are lots of other ways to do this anyways (e.g. just patching the code
or looking for the paravirt_ops struct signature in memory)

-Andi