Re: Please revert 21564fd2a3deb48200b595332f9ed4c9f311f2a7

Jeremy Fitzhardinge
2007-07-09T14:07:29Z

Alan Cox wrote:
> There were a considerable number of sensible logical objections. You just
> didn't agree with them. You've now effectively made .22 unsupportable
> since we don't know if someone has binary virtualiser crap loaded.

The pv_ops infrastructure doesn't support modular pv_ops
implementations, and if it did, there's certainly no intention of
supporting non-GPL implementations.

At the same time that all the other altinstruction patching happens, it
converts any indirect calls via paravirt_ops into direct calls to the
target function, bypassing struct paravirt_ops altogether. After that
the structure is pretty much only used for patching modules. Any
attempt at writing a modular pv_ops implementation would fail as a result.

J