cdparanoia not setting count and/or reply_len properly

cdparanoia not setting count and/or reply_len properly

[DervishD]

    Hi all :)

    I know, this has been treated on the list before (year 2005) but
without any real solution I'm aware of.

    I'm running kernel 2.6.20.14, and I have an ATAPI DVD writer that I
use with an IDE-to-USB adapter, so it appears as an SCSI drive to the
kernel.

    Anytime I rip anything with it, the log fills with the same message:
some numbers about a certain number of bytes and the old friend message
that I've put in the subject.

    I assume that the warning makes sense, but the fact is that my log
is full with the same message, the ripping is correct (so cdparanoia is
working OK WRT ripping) and if weren't for the printk_ratelimit, the
system will freeze.

    I don't know if cdparanoia should be fixed, but certainly the
warning could be issued only if CONFIG_SCSI_VERBOSE is set. This way you
will have the message if something goes wrong and you want more info,
but in cases where the warning is harmless your log will be clean...

    Anyway, this message is not for make suggestions, but for asking for
information: why is this warning happening? naugthy cdparanoia? naughty
kernel? I'm a bit confused and I want to use my external DVD drive for
ripping from time to time, to "exercise" it...

    Thanks a lot in advance :)

    Raúl Núñez de Arenas Coronado

-- 
Linux Registered User 88736 | http://www.dervishd.net
It's my PC and I'll cry if I want to... RAmen!

Re: cdparanoia not setting count and/or reply_len properly

[Stefan Richter]

DervishD wrote at lkml:
>     Hi all :)
> 
>     I know, this has been treated on the list before (year 2005) but
> without any real solution I'm aware of.
> 
>     I'm running kernel 2.6.20.14, and I have an ATAPI DVD writer that I
> use with an IDE-to-USB adapter, so it appears as an SCSI drive to the
> kernel.
> 
>     Anytime I rip anything with it, the log fills with the same message:
> some numbers about a certain number of bytes and the old friend message
> that I've put in the subject.
> 
>     I assume that the warning makes sense, but the fact is that my log
> is full with the same message, the ripping is correct (so cdparanoia is
> working OK WRT ripping) and if weren't for the printk_ratelimit, the
> system will freeze.
> 
>     I don't know if cdparanoia should be fixed, but certainly the
> warning could be issued only if CONFIG_SCSI_VERBOSE is set. This way you
> will have the message if something goes wrong and you want more info,
> but in cases where the warning is harmless your log will be clean...
> 
>     Anyway, this message is not for make suggestions, but for asking for
> information: why is this warning happening? naugthy cdparanoia? naughty
> kernel? I'm a bit confused and I want to use my external DVD drive for
> ripping from time to time, to "exercise" it...
> 
>     Thanks a lot in advance :)
> 
>     Raúl Núñez de Arenas Coronado
> 

This question is better asked at lsml.  (Therefore I'm quoting in full.)
-- 
Stefan Richter
-=====-=-=== -=== -=---
http://arcgraph.de/sr/

Re: cdparanoia not setting count and/or reply_len properly

[Douglas Gilbert]

Stefan Richter wrote:
> DervishD wrote at lkml:
>>     Hi all :)
>>
>>     I know, this has been treated on the list before (year 2005) but
>> without any real solution I'm aware of.
>>
>>     I'm running kernel 2.6.20.14, and I have an ATAPI DVD writer that I
>> use with an IDE-to-USB adapter, so it appears as an SCSI drive to the
>> kernel.
>>
>>     Anytime I rip anything with it, the log fills with the same message:
>> some numbers about a certain number of bytes and the old friend message
>> that I've put in the subject.
>>
>>     I assume that the warning makes sense, but the fact is that my log
>> is full with the same message, the ripping is correct (so cdparanoia is
>> working OK WRT ripping) and if weren't for the printk_ratelimit, the
>> system will freeze.
>>
>>     I don't know if cdparanoia should be fixed, but certainly the
>> warning could be issued only if CONFIG_SCSI_VERBOSE is set. This way you
>> will have the message if something goes wrong and you want more info,
>> but in cases where the warning is harmless your log will be clean...
>>
>>     Anyway, this message is not for make suggestions, but for asking for
>> information: why is this warning happening? naugthy cdparanoia? naughty
>> kernel? I'm a bit confused and I want to use my external DVD drive for
>> ripping from time to time, to "exercise" it...
>>
>>     Thanks a lot in advance :)
>>
>>     Raúl Núñez de Arenas Coronado
>>
> 
> This question is better asked at lsml.  (Therefore I'm quoting in full.)

In Fedora 7 I see this:

# cdparanoia --version
cdparanoia III release 9.8 (March 23, 2001)
(C) 2001 Monty <monty@xiph.org> and Xiphophorus

Report bugs to paranoia@xiph.org
http://www.xiph.org/paranoia/


So, given that date, lk 2.4.2 was out but it was probably
a bit early to start using the sg version 3 interface
which first appeared in lk 2.4.1 . So that "lets annoy
the user" message was added by someone who got burnt by
the old sg version 2 interface and decided people needed
to be warned. The warning comes from this code is sg.c :

        /*
         * SG_DXFER_TO_FROM_DEV is functionally equivalent to SG_DXFER_FROM_DEV,
         * but is is possible that the app intended SG_DXFER_TO_DEV, because the
re
         * is a non-zero input_size, so emit a warning.
         */
        if (hp->dxfer_direction == SG_DXFER_TO_FROM_DEV)
                if (printk_ratelimit())
                        printk(KERN_WARNING
                               "sg_write: data in/out %d/%d bytes for SCSI comma
nd 0x%x--"
                               "guessing data in;\n" KERN_WARNING "   "
                               "program %s not setting count and/or reply_len pr
operly\n",
                               old_hdr.reply_len - (int)SZ_SG_HEADER,
                               input_size, (unsigned int) cmnd[0],
                               current->comm);

That code wasn't written be me and I would gladly remove it.
For anyone who has read the sg driver documentation,
SG_DXFER_TO_FROM_DEV implies a _read_ from the device. The
reason SG_DXFER_TO_FROM_DEV exists is for backward
compatibility to the sg version 1 interface. It was a hack to
get around the fact that the SCSI subsystem didn't report short
reads (what folks should use 'resid' for) back in those days.


It is probably about time that cdparanoia was updated ...

Doug Gilbert

Re: cdparanoia not setting count and/or reply_len properly

[DervishD]

    Hi Douglas :)

 * Douglas Gilbert <dougg@torque.net> dixit:
> >>     I don't know if cdparanoia should be fixed, but certainly the
> >> warning could be issued only if CONFIG_SCSI_VERBOSE is set. This way you
> >> will have the message if something goes wrong and you want more info,
> >> but in cases where the warning is harmless your log will be clean...
> >>
> >>     Anyway, this message is not for make suggestions, but for asking for
> >> information: why is this warning happening? naugthy cdparanoia? naughty
> >> kernel? I'm a bit confused and I want to use my external DVD drive for
> >> ripping from time to time, to "exercise" it...
> 
> In Fedora 7 I see this:
> 
> # cdparanoia --version
> cdparanoia III release 9.8 (March 23, 2001)
> (C) 2001 Monty <monty@xiph.org> and Xiphophorus

    Same version here.

> So, given that date, lk 2.4.2 was out but it was probably
> a bit early to start using the sg version 3 interface
> which first appeared in lk 2.4.1 . So that "lets annoy
> the user" message was added by someone who got burnt by
> the old sg version 2 interface and decided people needed
> to be warned. The warning comes from this code is sg.c :

    OK, grand. So it's cdparanoia's fault.

>         /*
>          * SG_DXFER_TO_FROM_DEV is functionally equivalent to SG_DXFER_FROM_DEV,
>          * but is is possible that the app intended SG_DXFER_TO_DEV, because the
> re
>          * is a non-zero input_size, so emit a warning.
>          */
>         if (hp->dxfer_direction == SG_DXFER_TO_FROM_DEV)
>                 if (printk_ratelimit())
>                         printk(KERN_WARNING
>                                "sg_write: data in/out %d/%d bytes for SCSI comma
> nd 0x%x--"
>                                "guessing data in;\n" KERN_WARNING "   "
>                                "program %s not setting count and/or reply_len pr
> operly\n",
>                                old_hdr.reply_len - (int)SZ_SG_HEADER,
>                                input_size, (unsigned int) cmnd[0],
>                                current->comm);

    Yes, I did read the code, and I didn't find any reason for it to
exist, but I didn't understand the purpose of SG_DXFER_TO_FROM_DEV.
Thanks for explaining this :))

> It is probably about time that cdparanoia was updated ...

    I think the same, but given that it works, Monty probably doesn't
have much motivation to update it. I don't know if the problem resides
in the cdparanoia program itself (so using the DAE problem from cdrkit
will fix the issue) or in the paranoia library. In this case, the
problem will affect any program using the library.

    Anyway, if you need any testing, just tell :)

    Thanks a lot!

    Raúl Núñez de Arenas Coronado

-- 
Linux Registered User 88736 | http://www.dervishd.net
It's my PC and I'll cry if I want to... RAmen!

Re: cdparanoia not setting count and/or reply_len properly

[DervishD]

    Hi Stefan :)

 * Stefan Richter <stefanr@s5r6.in-berlin.de> dixit:
> >     I don't know if cdparanoia should be fixed, but certainly the
> > warning could be issued only if CONFIG_SCSI_VERBOSE is set. This way you
> > will have the message if something goes wrong and you want more info,
> > but in cases where the warning is harmless your log will be clean...
> > 
> >     Anyway, this message is not for make suggestions, but for asking for
> > information: why is this warning happening? naugthy cdparanoia? naughty
> > kernel? I'm a bit confused and I want to use my external DVD drive for
> > ripping from time to time, to "exercise" it...
> 
> This question is better asked at lsml.  (Therefore I'm quoting in full.)

    First time I hear about that list, sorry O:))) Thanks a lot for
forwarding, Stefan :)

    Raúl Núñez de Arenas Coronado

-- 
Linux Registered User 88736 | http://www.dervishd.net
It's my PC and I'll cry if I want to... RAmen!

Re: cdparanoia not setting count and/or reply_len properly

[Joerg Schilling]

>> It is probably about time that cdparanoia was updated ...

>    I think the same, but given that it works, Monty probably doesn't
>have much motivation to update it. I don't know if the problem resides
>in the cdparanoia program itself (so using the DAE problem from cdrkit
>will fix the issue) or in the paranoia library. In this case, the
>problem will affect any program using the library.

Do not try to replace one dead program by another one....

If you like actively maintained software you need to look here:

ftp://ftp.berlios.de/pub/cdrecord/alpha/

http://cdrecord.berlios.de/new/private/cdrecord.html

The main problem with cdparanoia is that it is based on a 10 year old cdda2wav.
Even if Monty did start working on it again, he would not change that.

Sending bad SCSI commands is a result of bad low level code from an 
extremely old cdda2wav version.

Libparanoia in cdrtools is based on the assets of the cdparanoia program.
The software has been made portable and several bugs have been removed by me.

BYW: The next plan with cdda2wav is to add C2-pointer support and to allow
libparanoia to know whether a sector was bad or not even if a bad sector
will re-read the same for every try. This will make cdda2wav behave better
with extremely bad/scratched media.

Jörg

-- 
 EMail:joerg@schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
       js@cs.tu-berlin.de                (uni)  
       schilling@fokus.fraunhofer.de     (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily

Re: cdparanoia not setting count and/or reply_len properly

[DervishD]

    Hi Joerg :)

 * Joerg Schilling <Joerg.Schilling@fokus.fraunhofer.de> dixit:
> >> It is probably about time that cdparanoia was updated ...
> 
> >    I think the same, but given that it works, Monty probably doesn't
> >have much motivation to update it. I don't know if the problem resides
> >in the cdparanoia program itself (so using the DAE problem from cdrkit
> >will fix the issue) or in the paranoia library. In this case, the
> >problem will affect any program using the library.
> 
> Do not try to replace one dead program by another one....

    Do you mean cdrkit?

    Raúl Núñez de Arenas Coronado

-- 
Linux Registered User 88736 | http://www.dervishd.net
It's my PC and I'll cry if I want to... RAmen!

Re: cdparanoia not setting count and/or reply_len properly

[Joerg Schilling]

DervishD <lkml@dervishd.net> wrote:

>     Hi Joerg :)

> > Do not try to replace one dead program by another one....
>
>     Do you mean cdrkit?

Correct.

Jörg

-- 
 EMail:joerg@schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
       js@cs.tu-berlin.de                (uni)  
       schilling@fokus.fraunhofer.de     (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily

Re: cdparanoia not setting count and/or reply_len properly

[Joerg Schilling]

>It is probably about time that cdparanoia was updated ...

>Doug Gilbert

Cdparanoia was not updated since 2001. The here important low level code is 
still the same as with cdda2wav from 1997.

For this reason, I did create a portable libparanoia from the assets of the 
cdparanoia code and also fixed several bugs in the paranoia code.
We then added this code to a recent cdda2wav in April 2002.

People need to learn that cdparanoia is dead and no longer maintained by Monty.
Monty is working on other software now. A recent maintained version is here:

ftp://ftp.berlios.de/pub/cdrecord/alpha/

http://cdrecord.berlios.de/new/private/cdrecord.html

Jörg

-- 
 EMail:joerg@schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
       js@cs.tu-berlin.de                (uni)  
       schilling@fokus.fraunhofer.de     (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily