From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754932AbaIXQv5 (ORCPT ); Wed, 24 Sep 2014 12:51:57 -0400 Received: from mail.kmu-office.ch ([178.209.48.102]:41250 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754915AbaIXQvz (ORCPT ); Wed, 24 Sep 2014 12:51:55 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset= Content-Transfer-Encoding: 7bit Date: Wed, 24 Sep 2014 18:51:16 +0200 From: Stefan Agner To: Lucas Stach Cc: shawn.guo@freescale.com, kernel@pengutronix.de, linus.walleij@linaro.org, gnurou@gmail.com, linux@arm.linux.org.uk, jingchang.lu@freescale.com, b20788@freescale.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 5/9] gpio: vf610: Extend with wakeup support In-Reply-To: <1411553179.2735.4.camel@pengutronix.de> References: <704b6bb97147b3d0ee1557b43d85ab9376c28666.1411404079.git.stefan@agner.ch> <1411553179.2735.4.camel@pengutronix.de> Message-ID: <46921955713f4b155eef9b21e5138064@agner.ch> User-Agent: Roundcube Webmail/1.0.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2014-09-24 12:06, schrieb Lucas Stach: > Hi Stefan, > > Am Montag, den 22.09.2014, 19:09 +0200 schrieb Stefan Agner: >> Support Vybrid GPIO's as wakeup source by requesting the parent >> IRQ as wakeup IRQ. >> >> Signed-off-by: Stefan Agner >> --- >> drivers/gpio/gpio-vf610.c | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c >> index 5f59424..50326af 100644 >> --- a/drivers/gpio/gpio-vf610.c >> +++ b/drivers/gpio/gpio-vf610.c >> @@ -196,12 +196,28 @@ static void vf610_gpio_irq_unmask(struct irq_data *d) >> pcr_base); >> } >> >> +static int vf610_gpio_irq_set_wake(struct irq_data *d, u32 enable) >> +{ >> + struct vf610_gpio_port *port = irq_data_get_irq_chip_data(d); >> + >> + if (enable) >> + enable_irq_wake(port->irq); >> + else >> + disable_irq_wake(port->irq); >> + >> + return 0; >> +} >> + >> + >> static struct irq_chip vf610_gpio_irq_chip = { >> .name = "gpio-vf610", >> .irq_ack = vf610_gpio_irq_ack, >> .irq_mask = vf610_gpio_irq_mask, >> .irq_unmask = vf610_gpio_irq_unmask, >> .irq_set_type = vf610_gpio_irq_set_type, >> +#ifdef CONFIG_PM_SLEEP >> + .irq_set_wake = vf610_gpio_irq_set_wake, >> +#endif > > Either you need to get rid of this #ifdef and always assign this > function or you need to wrap the function itself into the same #ifdef. > Otherwise you provoke a unused function warning with !CONFIG_PM_SLEEP. > > Given that this function isn't really that big I would argue to just > drop the #ifdef. > Good point, thx! I will drop the #ifdef when including that patch to the GPIO driver (as Linus Walleij suggested). -- Stefan