From: "Matthias Lenk" <matthias.lenk@amd.com>
To: "Andi Kleen" <ak@suse.de>
Cc: "Aaron Durbin" <adurbin@google.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] i386/x86_64: Insert HPET firmware resource after PCI enumeration has completed
Date: Mon, 09 Jul 2007 16:07:18 +0200 [thread overview]
Message-ID: <46924116.1080901@amd.com> (raw)
In-Reply-To: <468E22CF.6070602@amd.com>
Andi, Aaron,
I retested the patch with Andi's patch not reverted (that's the way it's
meant to be I guess) and then it works! I can now boot with HPET enabled.
Thanks,
Matthias
Matthias Lenk wrote:
> Aaron, I tested the patch on my affected system and unfortunately it
> did not work. The BAR1 resource still gets overridden and hence the
> same effects as before.
>
> Thanks,
>
> Matthias
>
> Andi Kleen wrote:
>> On Friday 06 July 2007 00:27:24 Aaron Durbin wrote:
>>
>>> Insert HPET resources after pci probing has been completed in order
>>> to avoid
>>> resource conflicts with PCI resource reservation. With this change the
>>> HPET firmware resources will be identified, but it should also not
>>> cause
>>> issues when the HPET address falls on a BAR in a PCI device, and the
>>> PCI
>>> enumeration cannot reserve the resources.
>>>
>>
>> But what advantage does it have when it's already reserved by PCI?
>>
>> That's only a cosmetic change, isn't it? A lot of code for cosmetics.
>>
>> -Andi
>>
>>
>>
>
>
>
next prev parent reply other threads:[~2007-07-09 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 22:27 [PATCH] i386/x86_64: Insert HPET firmware resource after PCI enumeration has completed Aaron Durbin
2007-07-06 10:59 ` Andi Kleen
2007-07-06 11:09 ` Matthias Lenk
2007-07-09 14:07 ` Matthias Lenk [this message]
2007-07-06 12:45 ` Aaron Durbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46924116.1080901@amd.com \
--to=matthias.lenk@amd.com \
--cc=adurbin@google.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox