public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@sgi.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-kernel@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>
Subject: Re: 2.6.3-rc3 serial console woes
Date: Tue, 17 Feb 2004 12:53:21 +1100	[thread overview]
Message-ID: <4693.1076982801@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Mon, 16 Feb 2004 16:45:14 PDT." <200402161645.14151.bjorn.helgaas@hp.com>

On Mon, 16 Feb 2004 16:45:14 -0700, 
Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>Reverting for now sounds like the right thing to me.  I would like to
>understand what's going on, though.

My bad, patch merge error against kdb.  Your one line patch is all that
is required.  I have included it in kdb-v4.3-2.6.3-rc3-common-1 to
ensure that kdb works.

===== drivers/serial/8250.c 1.44 vs edited =====
--- 1.44/drivers/serial/8250.c	Fri Feb 13 08:19:33 2004
+++ edited/drivers/serial/8250.c	Mon Feb 16 12:03:06 2004
@@ -1976,7 +1976,7 @@
 	if (co->index >= UART_NR)
 		co->index = 0;
 	port = &serial8250_ports[co->index].port;
-	if (port->type == PORT_UNKNOWN)
+	if (!port->ops)
 		return -ENODEV;
 
 	/*



      reply	other threads:[~2004-02-17  1:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-16 13:14 2.6.3-rc3 serial console woes Keith Owens
2004-02-16 19:07 ` Bjorn Helgaas
2004-02-16 21:05   ` Keith Owens
2004-02-16 23:25     ` Keith Owens
2004-02-16 23:45       ` Bjorn Helgaas
2004-02-17  1:53         ` Keith Owens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4693.1076982801@kao2.melbourne.sgi.com \
    --to=kaos@sgi.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox