From: Yinghai Lu <Yinghai.Lu@Sun.COM>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: do not add port that is not initialized
Date: Wed, 11 Jul 2007 13:45:04 -0700 [thread overview]
Message-ID: <46954150.7050707@sun.com> (raw)
In-Reply-To: <20070711194050.GB28258@flint.arm.linux.org.uk>
Russell King wrote:
> On Wed, Jul 11, 2007 at 10:05:53AM -0600, Bjorn Helgaas wrote:
>> On Wednesday 11 July 2007 01:17:42 am Russell King wrote:
>>> On Tue, Jul 10, 2007 at 05:03:35PM -0700, Yinghai Lu wrote:
>>>> [PATCH] serial: do not add port that is not initialized
>>>>
>>>> if the port is not initialized with correct iobase, and membase, we don't
>>>> need to add that port.
>>>> for x86, when pnpacpi is enabled, we will not get extra ttyS1/ttyS2/ttyS3 in
>>>> /sys/devices/platform/serial8250/tty
>>>>
>>>> Sign-off-by: Yinghai Lu <yinghai.lu@sun.com>
>>> What if someone wants to run setserial on /dev/ttyS1 to set it's base
>>> address, irq and other parameters? People still do this.
>> I agree that people still use setserial that way, and we shouldn't
>> make this change because it would break things.
>>
>> But I also agree with Yinghai that these extra phantom devices are
>> just weird. It would be a lot nicer if there were a way to say,
>> "please, Mr. Serial Driver, create me a new ttyS device with these
>> parameters."
>>
>> But no, I'm not volunteering to do that.
>
> Indeed, and since distros still haven't picked up my setserial v3,
> I see little chance of that ever being practical. Not that I've
> really tried very hard to get them to - no real idea who to contact
> to make that happen, and of course I've no interest in making it
> happen anymore.
so remove these extra phantom devices, the kernel distros will use your setserial v3.
we can put some comments in code, so later they will find clue about your setserial v3.
YH
next prev parent reply other threads:[~2007-07-11 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 0:03 [PATCH] serial: do not add port that is not initialized Yinghai Lu
2007-07-11 7:17 ` Russell King
2007-07-11 16:05 ` Bjorn Helgaas
2007-07-11 19:40 ` Russell King
2007-07-11 20:45 ` Yinghai Lu [this message]
2007-07-11 21:48 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46954150.7050707@sun.com \
--to=yinghai.lu@sun.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox