Re: [PATCH] serial: do not add port that is not initialized

Russell King
2007-07-11T19:42:00Z

On Wed, Jul 11, 2007 at 10:05:53AM -0600, Bjorn Helgaas wrote:
> On Wednesday 11 July 2007 01:17:42 am Russell King wrote:
> > On Tue, Jul 10, 2007 at 05:03:35PM -0700, Yinghai Lu wrote:
> > > [PATCH] serial: do not add port that is not initialized
> > >
> > > if the port is not initialized with correct iobase, and membase, we don't
> > > need to add that port.
> > > for x86, when pnpacpi is enabled, we will not get extra ttyS1/ttyS2/ttyS3 in
> > > /sys/devices/platform/serial8250/tty
> > >
> > > Sign-off-by: Yinghai Lu <yinghai.lu@sun.com>
> >
> > What if someone wants to run setserial on /dev/ttyS1 to set it's base
> > address, irq and other parameters? People still do this.
>
> I agree that people still use setserial that way, and we shouldn't
> make this change because it would break things.
>
> But I also agree with Yinghai that these extra phantom devices are
> just weird. It would be a lot nicer if there were a way to say,
> "please, Mr. Serial Driver, create me a new ttyS device with these
> parameters."
>
> But no, I'm not volunteering to do that.

Indeed, and since distros still haven't picked up my setserial v3,
I see little chance of that ever being practical. Not that I've
really tried very hard to get them to - no real idea who to contact
to make that happen, and of course I've no interest in making it
happen anymore.