From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758572AbXGLTEo (ORCPT ); Thu, 12 Jul 2007 15:04:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753119AbXGLTEd (ORCPT ); Thu, 12 Jul 2007 15:04:33 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:54986 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbXGLTEc (ORCPT ); Thu, 12 Jul 2007 15:04:32 -0400 Message-ID: <46967B3C.708@garzik.org> Date: Thu, 12 Jul 2007 15:04:28 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: dean gaudet CC: linux-ide@vger.kernel.org, LKML , dave@thedillows.org Subject: Re: [RFT][PATCH v7] sata_mv: convert to new EH References: <20070711200538.GA7374@havoc.gtf.org> <46960225.5000502@garzik.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org dean gaudet wrote: > On Thu, 12 Jul 2007, Jeff Garzik wrote: > >> dean gaudet wrote: >>> oh very nice... no warnings on boot, and no warnings while i "dd if=/dev/sdX >>> of=/dev/null" and i'm seeing 74MB/s+ from each disk on this simple read >>> test. >>> >>> for lack of a better test i started an untar/diff stress test on the >>> disks... we'll see how it goes. (it's based on doug ledford's memtest.sh) >> Thanks for the testing. Looks like we might have hit on something good... > > yep this does look good. no problems overnight in the untar/diff/rm > workload. if you've got any other workload you'd like me to throw at it, > let me know. i might be able to scare up a disk or two with errors to > check error handling. Nothing specific. I usually just throw various workloads at it, both throughput-intensive, seek-intensive, multiple threads at the same time, stressing multiple disks at the same time, etc. I presume from your past messages your tests include multiple disks at the same time? > i tested hotplug just for kicks... no luck there :) but then you didn't > say that would work yet. hehehe Well I sorta didn't want to mention it, to avoid clouding the waters further. In theory, hotplug and hot unplug -should- work, in version 7. Your report is a useful contradiction of that theory, and signals where to poke next. Since all this hacking is a spare-time effort, so promises as to when next I'll poke at it. It might be tomorrow, or a month from now. Getting "new EH" upstream was a big hurdle to overcome, and your testing really helped that along. Anyway, something like Version 7 is probably what I will push upstream for 2.6.23-rc1. Jeff