From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: LABBE Corentin <clabbe.montjoie@gmail.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
maxime.ripard@free-electrons.com, wens@csie.org,
linux@armlinux.org.uk, davem@davemloft.net,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 1/5] ethernet: add sun8i-emac driver
Date: Wed, 20 Jul 2016 11:56:12 +0200 [thread overview]
Message-ID: <4697175.RMdFEWr9V5@wuerfel> (raw)
In-Reply-To: <1469001800-11615-2-git-send-email-clabbe.montjoie@gmail.com>
On Wednesday, July 20, 2016 10:03:16 AM CEST LABBE Corentin wrote:
> +
> + /* Benched on OPIPC with 100M, setting more than 256 does not give any
> + * perf boost
> + */
> + priv->nbdesc_rx = 128;
> + priv->nbdesc_tx = 256;
> +
>
256 tx descriptors can introduce a significant latency. Can you add
support for BQL (netdev_sent_queue/netdev_completed_queue) to limit
the queue size to the minimum?
I also noticed that your tx_lock() prevents you from concurrently
running sun8i_emac_complete_xmit() and sun8i_emac_xmit(). Is that
necessary? I'd think that you can find a way to make them work
concurrently.
Arnd
next prev parent reply other threads:[~2016-07-20 9:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 8:03 [PATCH v2 0/5] net-next: ethernet: add sun8i-emac driver LABBE Corentin
2016-07-20 8:03 ` [PATCH v2 1/5] " LABBE Corentin
2016-07-20 9:56 ` Arnd Bergmann [this message]
2016-07-28 13:18 ` LABBE Corentin
2016-07-29 9:26 ` Arnd Bergmann
2016-07-25 19:54 ` Maxime Ripard
2016-07-28 14:57 ` LABBE Corentin
2016-07-29 17:25 ` Maxime Ripard
2016-07-30 1:30 ` Chen-Yu Tsai
2016-07-30 7:34 ` Maxime Ripard
2016-07-29 10:12 ` Andre Przywara
2016-08-24 12:02 ` LABBE Corentin
2016-08-26 20:49 ` Maxime Ripard
2016-07-20 8:03 ` [PATCH v2 2/5] MAINTAINERS: Add myself as maintainers of sun8i-emac LABBE Corentin
2016-07-20 8:03 ` [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac LABBE Corentin
2016-07-20 19:15 ` Rob Herring
2016-07-28 13:21 ` LABBE Corentin
2016-07-21 7:55 ` Maxime Ripard
2016-07-28 13:40 ` LABBE Corentin
2016-07-28 18:49 ` Maxime Ripard
2016-07-29 8:15 ` LABBE Corentin
2016-07-29 18:12 ` Maxime Ripard
2016-07-20 8:03 ` [PATCH v2 4/5] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver LABBE Corentin
2016-07-20 8:03 ` [PATCH v2 5/5] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC LABBE Corentin
2016-07-25 13:16 ` [PATCH v2 0/5] net-next: ethernet: add sun8i-emac driver paulo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4697175.RMdFEWr9V5@wuerfel \
--to=arnd@arndb.de \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox