* [PATCH] broken lilo check on make install
@ 2007-07-12 20:56 Gabriel C
2007-07-13 22:29 ` H. Peter Anvin
0 siblings, 1 reply; 3+ messages in thread
From: Gabriel C @ 2007-07-12 20:56 UTC (permalink / raw)
To: linux Kernel Mailing List; +Cc: trivial
Hello,
on make install I get the this error:
...
sh /work/crazy/linux-git/linux-2.6/arch/i386/boot/install.sh
2.6.22-g4eb6bf6b arch/i386/boot/bzImage System.map "/boot"
/work/crazy/linux-git/linux-2.6/arch/i386/boot/install.sh: line 54:
/etc/lilo/install: No such file or directory
make[1]: *** [install] Error 127
...
I don't use and don't have lilo installed on this system. The attached
patch fixes the problem for me.
Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
diff --git a/arch/i386/boot/install.sh b/arch/i386/boot/install.sh
index 5e44c73..7099fd6 100644
--- a/arch/i386/boot/install.sh
+++ b/arch/i386/boot/install.sh
@@ -51,4 +51,10 @@ fi
cat $2 > $4/vmlinuz
cp $3 $4/System.map
-if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
+if [ -x /sbin/lilo ]; then
+ /sbin/lilo
+elif [ -x /etc/lilo/install ]; then
+ /etc/lilo/install
+else
+ echo "Cannot find LILO."
+fi
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] broken lilo check on make install
2007-07-12 20:56 [PATCH] broken lilo check on make install Gabriel C
@ 2007-07-13 22:29 ` H. Peter Anvin
2007-07-14 9:59 ` Gabriel C
0 siblings, 1 reply; 3+ messages in thread
From: H. Peter Anvin @ 2007-07-13 22:29 UTC (permalink / raw)
To: Gabriel C; +Cc: linux Kernel Mailing List, trivial
Gabriel C wrote:
>
> I don't use and don't have lilo installed on this system. The attached
> patch fixes the problem for me.
>
You also don't have a /sbin/installkernel, which is arguably a bug too.
However, the patch mostly makes sense, although I would suggest putting
a "sync" in the else clause.
With that caveat, Acked-by: H. Peter Anvin <hpa@zytor.com>
> Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
>
>
> diff --git a/arch/i386/boot/install.sh b/arch/i386/boot/install.sh
> index 5e44c73..7099fd6 100644
> --- a/arch/i386/boot/install.sh
> +++ b/arch/i386/boot/install.sh
> @@ -51,4 +51,10 @@ fi
> cat $2 > $4/vmlinuz
> cp $3 $4/System.map
>
> -if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
> +if [ -x /sbin/lilo ]; then
> + /sbin/lilo
> +elif [ -x /etc/lilo/install ]; then
> + /etc/lilo/install
> +else
> + echo "Cannot find LILO."
> +fi
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] broken lilo check on make install
2007-07-13 22:29 ` H. Peter Anvin
@ 2007-07-14 9:59 ` Gabriel C
0 siblings, 0 replies; 3+ messages in thread
From: Gabriel C @ 2007-07-14 9:59 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: linux Kernel Mailing List, trivial
H. Peter Anvin wrote:
> Gabriel C wrote:
>
>> I don't use and don't have lilo installed on this system. The attached
>> patch fixes the problem for me.
>>
>>
>
> You also don't have a /sbin/installkernel, which is arguably a bug too.
> However, the patch mostly makes sense, although I would suggest putting
> a "sync" in the else clause.
>
Ok , I've changed the patch to use sync.
> With that caveat, Acked-by: H. Peter Anvin <hpa@zytor.com>
>
>
Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
arch/i386/boot/install.sh | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/arch/i386/boot/install.sh b/arch/i386/boot/install.sh
index 5e44c73..cb55f67 100644
--- a/arch/i386/boot/install.sh
+++ b/arch/i386/boot/install.sh
@@ -51,4 +51,11 @@ fi
cat $2 > $4/vmlinuz
cp $3 $4/System.map
-if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
+if [ -x /sbin/lilo ]; then
+ /sbin/lilo
+elif [ -x /etc/lilo/install ]; then
+ /etc/lilo/install
+else
+ sync
+ echo "Cannot find LILO."
+fi
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-14 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-12 20:56 [PATCH] broken lilo check on make install Gabriel C
2007-07-13 22:29 ` H. Peter Anvin
2007-07-14 9:59 ` Gabriel C
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox