Re: [PATCH] broken lilo check on make install

H. Peter Anvin
2007-07-13T22:29:33Z

Gabriel C wrote:
>
> I don't use and don't have lilo installed on this system. The attached
> patch fixes the problem for me.
>

You also don't have a /sbin/installkernel, which is arguably a bug too.
However, the patch mostly makes sense, although I would suggest putting
a "sync" in the else clause.

With that caveat, Acked-by: H. Peter Anvin <hpa@zytor.com>

> Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
>
>
> diff --git a/arch/i386/boot/install.sh b/arch/i386/boot/install.sh
> index 5e44c73..7099fd6 100644
> --- a/arch/i386/boot/install.sh
> +++ b/arch/i386/boot/install.sh
> @@ -51,4 +51,10 @@ fi
> cat $2 > $4/vmlinuz
> cp $3 $4/System.map
>
> -if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
> +if [ -x /sbin/lilo ]; then
> + /sbin/lilo
> +elif [ -x /etc/lilo/install ]; then
> + /etc/lilo/install
> +else
> + echo "Cannot find LILO."
> +fi
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/