Re: [PATCH] broken lilo check on make install

Gabriel C
2007-07-14T10:00:24Z

H. Peter Anvin wrote:
> Gabriel C wrote:
>
>> I don't use and don't have lilo installed on this system. The attached
>> patch fixes the problem for me.
>>
>>
>
> You also don't have a /sbin/installkernel, which is arguably a bug too.
> However, the patch mostly makes sense, although I would suggest putting
> a "sync" in the else clause.
>

Ok , I've changed the patch to use sync.

> With that caveat, Acked-by: H. Peter Anvin <hpa@zytor.com>
>
>

Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>

arch/i386/boot/install.sh | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/arch/i386/boot/install.sh b/arch/i386/boot/install.sh
index 5e44c73..cb55f67 100644
--- a/arch/i386/boot/install.sh
+++ b/arch/i386/boot/install.sh
@@ -51,4 +51,11 @@ fi
cat $2 > $4/vmlinuz
cp $3 $4/System.map

-if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi
+if [ -x /sbin/lilo ]; then
+ /sbin/lilo
+elif [ -x /etc/lilo/install ]; then
+ /etc/lilo/install
+else
+ sync
+ echo "Cannot find LILO."
+fi