From: Jeff Garzik <jeff@garzik.org>
To: surya.prabhakar@wipro.com
Cc: caglar@pardus.org.tr, linux-kernel@vger.kernel.org,
kkeil@suse.de, kai.germaschewski@gmx.de,
isdn4linux@listserv.isdn4linux.de, akpm@linux-foundation.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get_device
Date: Sun, 15 Jul 2007 03:40:06 -0400 [thread overview]
Message-ID: <4699CF56.7010304@garzik.org> (raw)
In-Reply-To: <4699A9AD.2050206@garzik.org>
To be more clear, your solution is incorrect unless the pci_dev_put()
occurs after the last reference to hw.{elsa,diva,hfc,njet,...}.dev,
which is where the HiSax ISDN drivers store their reference to struct
pci_dev during the runtime life of the PCI device.
Am I missing where your patch does this?
By way of further interest, a few hours _before_ (yes, really) I saw
your patches, I resumed converting the ISDN HiSax PCI drivers to use the
PCI driver API. You can find this work in
git://git.kernel.org/.../jgarzik/misc-2.6.git#isdn-pci.
If you fix your patches' lifetime problems, I will ACK them myself,
since my effort is a spare time effort. But just wanted you to be aware
that I am deep into the code you are fixing, and can at least speak
somewhat knowledgeably on the specific lines of code you are changing.
Jeff
next prev parent reply other threads:[~2007-07-15 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 22:44 [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get_device S.Çağlar Onur
2007-07-15 0:40 ` Jeff Garzik
[not found] ` <A94AD757879CE142B7CEBC3E6FF5D3EC015DAC49@BLR-EC-MBX02.wipro.com>
2007-07-15 4:59 ` Jeff Garzik
2007-07-15 7:40 ` Jeff Garzik [this message]
2007-07-15 10:11 ` Surya Prabhakar N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4699CF56.7010304@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=caglar@pardus.org.tr \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=surya.prabhakar@wipro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox