Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

David Chinner
2007-07-12T04:16:34Z

On Wed, Jul 11, 2007 at 07:16:34PM +0200, Jesper Juhl wrote:
> Hi,
>
> I'm wondering if it's time to make 4K stacks the default and to start
> considering removing the 8K stack option alltogether soon?
>
> One of the big problem spots was XFS, but that got some stack usage
> fixes recently, and the 4K stack option has been around for quite a
> while now, so people really should have gotten around to fixing any
> code that can't handle it. Are there still any big problem areas
> remaining?

Yes. NFS on top of XFS on top of DM/MD.

XFS got some fixes recently, of which the main one was to fix the
regressions that gcc 4.x introduced by inlining single use functions
that we'd split out of the common code to reduce stack usage. So in
reality, there hasn't been a great deal of change in the status quo
here.

In fact, things have probably got worse because the generic
writeback code is slowly increasing it's stack usage....

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group