* [PATCH 2.6.22.1] libata: Adjust libata to ignore errors after spinup [not found] ` <46982875.60503@rtr.ca> @ 2007-07-16 3:28 ` Ryan Power 2007-07-16 23:07 ` Mark Lord 0 siblings, 1 reply; 4+ messages in thread From: Ryan Power @ 2007-07-16 3:28 UTC (permalink / raw) To: linux-ide; +Cc: jgarzik, Mark Lord, Tejun Heo, linux-kernel From: Ryan Power <rpower@sysreset.com> Adjust libata to ignore errors after spinup This patch is to ignore errors from the spinup attempt if the drive is in the "standby id" state. Signed-off-by: Ryan Power <rpower@sysreset.com> --- Index: drivers.new/ata/libata-core.c --- drivers/ata/libata-core.c 2007-07-10 12:56:30.000000000 -0600 +++ drivers.new/ata/libata-core.c 2007-07-15 01:58:49.000000000 -0600 @@ -1750,7 +1750,7 @@ int ata_dev_read_id(struct ata_device *d tf.protocol = ATA_PROT_NODATA; tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE; err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0); - if (err_mask) { + if (err_mask && id[2] != 0x738c) { rc = -EIO; reason = "SPINUP failed"; goto err_out; ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.22.1] libata: Adjust libata to ignore errors after spinup 2007-07-16 3:28 ` [PATCH 2.6.22.1] libata: Adjust libata to ignore errors after spinup Ryan Power @ 2007-07-16 23:07 ` Mark Lord 2007-07-16 23:15 ` Mark Lord 0 siblings, 1 reply; 4+ messages in thread From: Mark Lord @ 2007-07-16 23:07 UTC (permalink / raw) To: Ryan Power, jgarzik, Tejun Heo; +Cc: linux-ide, linux-kernel Ryan Power wrote: > From: Ryan Power <rpower@sysreset.com> > > Adjust libata to ignore errors after spinup > > This patch is to ignore errors from the spinup attempt if the drive is > in the "standby id" state. Jeff / Tejun: here is Ryan's patch for his WD drive spinup problems. This copy has the pathnames and whitespace repaired. Signed-off-by: Ryan Power <rpower@sysreset.com> Signed-off-by: Mark Lord <mlord@pobox.com> --- Index: linux/drivers/ata/libata-core.c --- old/drivers/ata/libata-core.c 2007-07-10 12:56:30.000000000 -0600 +++ linux/drivers/ata/libata-core.c 2007-07-15 01:58:49.000000000 -0600 @@ -1750,7 +1750,7 @@ int ata_dev_read_id(struct ata_device *d tf.protocol = ATA_PROT_NODATA; tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE; err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0); - if (err_mask) { + if (err_mask && id[2] != 0x738c) { rc = -EIO; reason = "SPINUP failed"; goto err_out; ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.22.1] libata: Adjust libata to ignore errors after spinup 2007-07-16 23:07 ` Mark Lord @ 2007-07-16 23:15 ` Mark Lord 2007-07-16 23:19 ` Mark Lord 0 siblings, 1 reply; 4+ messages in thread From: Mark Lord @ 2007-07-16 23:15 UTC (permalink / raw) To: Ryan Power, jgarzik, Tejun Heo; +Cc: linux-ide, linux-kernel Mark Lord wrote: > Ryan Power wrote: >> From: Ryan Power <rpower@sysreset.com> >> >> Adjust libata to ignore errors after spinup >> >> This patch is to ignore errors from the spinup attempt if the drive is >> in the "standby id" state. > > Jeff / Tejun: here is Ryan's patch for his WD drive spinup problems. > This copy has the pathnames and whitespace repaired. Mmm.. something weird happened there. Here it is again, with corrected whitespace. Signed-off-by: Ryan Power <rpower@sysreset.com> Signed-off-by: Mark Lord <mlord@pobox.com> --- Index: linux/drivers/ata/libata-core.c --- old/drivers/ata/libata-core.c 2007-07-10 12:56:30.000000000 -0600 +++ linux/drivers/ata/libata-core.c 2007-07-15 01:58:49.000000000 -0600 @@ -1750,7 +1750,7 @@ int ata_dev_read_id(struct ata_device *d tf.protocol = ATA_PROT_NODATA; tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE; err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0); - if (err_mask) { + if (err_mask && id[2] != 0x738c) { rc = -EIO; reason = "SPINUP failed"; goto err_out; ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.22.1] libata: Adjust libata to ignore errors after spinup 2007-07-16 23:15 ` Mark Lord @ 2007-07-16 23:19 ` Mark Lord 0 siblings, 0 replies; 4+ messages in thread From: Mark Lord @ 2007-07-16 23:19 UTC (permalink / raw) To: Ryan Power, jgarzik, Tejun Heo; +Cc: linux-ide, linux-kernel Mark Lord wrote: > Ryan Power wrote: >> From: Ryan Power <rpower@sysreset.com> >> >> Adjust libata to ignore errors after spinup >> >> This patch is to ignore errors from the spinup attempt if the drive is >> in the "standby id" state. > > Jeff / Tejun: here is Ryan's patch for his WD drive spinup problems. > This copy has the pathnames and whitespace repaired. Mmm.. Thunderbird-2.x seems to no longer keep my whitespace intact, even when using the external editor plugin.. Hopefully this one (posted with thunderbird-1.5 + exteditor.xpi) works: Signed-off-by: Ryan Power <rpower@sysreset.com> Signed-off-by: Mark Lord <mlord@pobox.com> --- Index: linux/drivers/ata/libata-core.c --- old/drivers/ata/libata-core.c 2007-07-10 12:56:30.000000000 -0600 +++ linux/drivers/ata/libata-core.c 2007-07-15 01:58:49.000000000 -0600 @@ -1750,7 +1750,7 @@ int ata_dev_read_id(struct ata_device *d tf.protocol = ATA_PROT_NODATA; tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE; err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0); - if (err_mask) { + if (err_mask && id[2] != 0x738c) { rc = -EIO; reason = "SPINUP failed"; goto err_out; ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-16 23:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <6.2.0.14.2.20070713000748.031a2660@linux.sysreset.com>
[not found] ` <469775E0.2000609@rtr.ca>
[not found] ` <6.2.0.14.2.20070713184231.02db2d20@linux.sysreset.com>
[not found] ` <46982875.60503@rtr.ca>
2007-07-16 3:28 ` [PATCH 2.6.22.1] libata: Adjust libata to ignore errors after spinup Ryan Power
2007-07-16 23:07 ` Mark Lord
2007-07-16 23:15 ` Mark Lord
2007-07-16 23:19 ` Mark Lord
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox