From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jeremy Fitzhardinge <jeremy@xensource.com>,
Linus Torvalds <torvalds@linux-foundation.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Xen-devel <xen-devel@lists.xensource.com>,
Bj?rn Steinbrink <B.Steinbrink@gmx.de>, Andi Kleen <ak@suse.de>,
lkml <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@linux-foundation.com>
Subject: Re: [Xen-devel] [patch 03/44] usermodehelper: split setup from execution
Date: Mon, 16 Jul 2007 17:57:34 -0700 [thread overview]
Message-ID: <469C13FE.6050606@goop.org> (raw)
In-Reply-To: <1184632870.5955.26.camel@localhost.localdomain>
Rusty Russell wrote:
> The patch seems fine, but the names are awkward. They've always been
> awkward (it's *userspace* helper, not *usermode* helper), but this just
> shines a bright light on them.
>
> So how about:
>
> call_usermodehelper_setup -> create_userspace_helper
> call_usermodehelper_<SET_EXTRA_STATE> -> userspace_helper_...
> call_usermodehelper_exec -> run_userspace_helper
>
> I can do that as a separate patch if you prefer (but it'd be nice to
> have it in the same merge window so the interface only churns once).
I don't have any particular objection, but I think it would be nicer if
they had a common prefix so that they're obviously related, and you can
easily infer the lifetime of the info structure.
J
next prev parent reply other threads:[~2007-07-17 0:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070716231536.937393000@xensource.com>
[not found] ` <20070716232912.409821000@xensource.com>
2007-07-17 0:41 ` [Xen-devel] [patch 03/44] usermodehelper: split setup from execution Rusty Russell
2007-07-17 0:57 ` Jeremy Fitzhardinge [this message]
[not found] ` <20070716232914.029797000@xensource.com>
2007-07-17 0:45 ` [Xen-devel] [patch 17/44] Add nosegneg capability to the vsyscall page notes Rusty Russell
2007-07-17 1:04 ` Jeremy Fitzhardinge
[not found] ` <20070716232916.472694000@xensource.com>
2007-07-17 1:07 ` [patch 37/44] xen: add virtual network device driver Jeff Garzik
2007-07-17 8:45 ` Stephen Hemminger
2007-07-17 14:28 ` Jeremy Fitzhardinge
2007-07-17 23:45 ` Rusty Russell
2007-07-18 0:40 ` Jeremy Fitzhardinge
[not found] ` <20070716232915.672717000@xensource.com>
2007-10-30 9:10 ` [Xen-devel] [patch 30/44] xen: Add support for preemption tgh
2007-10-30 17:25 ` Jeremy Fitzhardinge
2007-10-31 1:23 ` tgh
2007-10-31 1:38 ` Jeremy Fitzhardinge
2007-10-31 6:11 ` tgh
2007-10-31 15:07 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469C13FE.6050606@goop.org \
--to=jeremy@goop.org \
--cc=B.Steinbrink@gmx.de \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.com \
--cc=dhowells@redhat.com \
--cc=jeremy@xensource.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox