From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Jeff Dike <jdike@addtoit.com>,
LKML <linux-kernel@vger.kernel.org>,
KVM devel <kvm-devel@lists.sourceforge.net>
Subject: Re: [PATCH 2/3] KVM - Fix hypercall arguments
Date: Tue, 17 Jul 2007 11:15:26 +0300 [thread overview]
Message-ID: <469C7A9E.30207@qumranet.com> (raw)
In-Reply-To: <20070716192447.GA16248@c2.user-mode-linux.org>
Jeff Dike wrote:
> It looks like kvm_hypercall is trying to match the system call
> convention and mixed up the call number and first argument in the
> 32-bit case.
>
> Signed-off-by: Jeff Dike <jdike@linux.intel.com>
> --
> drivers/kvm/kvm_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: kvm/drivers/kvm/kvm_main.c
> ===================================================================
> --- kvm.orig/drivers/kvm/kvm_main.c
> +++ kvm/drivers/kvm/kvm_main.c
> @@ -1351,8 +1351,8 @@ int kvm_hypercall(struct kvm_vcpu *vcpu,
> } else
> #endif
> {
> - nr = vcpu->regs[VCPU_REGS_RBX] & -1u;
> - a0 = vcpu->regs[VCPU_REGS_RAX] & -1u;
> + nr = vcpu->regs[VCPU_REGS_RAX] & -1u;
> + a0 = vcpu->regs[VCPU_REGS_RBX] & -1u;
> a1 = vcpu->regs[VCPU_REGS_RCX] & -1u;
> a2 = vcpu->regs[VCPU_REGS_RDX] & -1u;
> a3 = vcpu->regs[VCPU_REGS_RSI] & -1u;
>
Anthony? I think you were hacking this area?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2007-07-17 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 19:24 [PATCH 2/3] KVM - Fix hypercall arguments Jeff Dike
2007-07-17 8:15 ` Avi Kivity [this message]
2007-07-17 13:42 ` [kvm-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469C7A9E.30207@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=jdike@addtoit.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox