Re: [kvm-devel] [PATCH 2/3] KVM - Fix hypercall arguments

[Anthony Liguori <anthony@codemonkey.ws>]

Avi Kivity wrote:
> Jeff Dike wrote:
>   
>> It looks like kvm_hypercall is trying to match the system call
>> convention and mixed up the call number and first argument in the
>> 32-bit case.
>>
>> Signed-off-by: Jeff Dike <jdike@linux.intel.com>
>> --
>>  drivers/kvm/kvm_main.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Index: kvm/drivers/kvm/kvm_main.c
>> ===================================================================
>> --- kvm.orig/drivers/kvm/kvm_main.c
>> +++ kvm/drivers/kvm/kvm_main.c
>> @@ -1351,8 +1351,8 @@ int kvm_hypercall(struct kvm_vcpu *vcpu,
>>  	} else
>>  #endif
>>  	{
>> -		nr = vcpu->regs[VCPU_REGS_RBX] & -1u;
>> -		a0 = vcpu->regs[VCPU_REGS_RAX] & -1u;
>> +		nr = vcpu->regs[VCPU_REGS_RAX] & -1u;
>> +		a0 = vcpu->regs[VCPU_REGS_RBX] & -1u;
>>  		a1 = vcpu->regs[VCPU_REGS_RCX] & -1u;
>>  		a2 = vcpu->regs[VCPU_REGS_RDX] & -1u;
>>  		a3 = vcpu->regs[VCPU_REGS_RSI] & -1u;
>>   
>>     
>
> Anthony?  I think you were hacking this area?
>   

I make a similar change in my series.

Regards,

Anthony Liguori