Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

Jesper Juhl
2007-07-16T23:52:17Z

On 17/07/07, Bodo Eggert <7eggert@gmx.de> wrote:
> On Tue, 17 Jul 2007, Jesper Juhl wrote:
>
> > Please note that I was not trying to remove the 8K stack option right
> > now - heck, I didn't even add anything to feature-removal-schedule.txt
> > - all I wanted to accomplish with the patch that started this threas
> > was; a) indicate that the 4K option is no longer a debug thing and
>
> Very ACK.
>
Ok, so perhaps a patch to do just that bit could go towards mainline
(possibly after a short stay in -mm).

> > b) make 4K stacks the default option in vanilla kernel.org kernels as
> > a gentle nudge towards getting people to start fixing the code paths
> > that are not 4K stack safe.
>
> That's the big NACK. It's OK for MM, where things are supposed to be in a
> not well-tested state, but for running possibly mission-critical systems,
> you should take no risk.
>
Hmm, I guess it would make sense to stick it in -mm for an extended
period of time, but hold off on mainline until we start hearing
positive noises that people can no longer break 4K stacks...

> If you'd run a 4K stack on the NFS+XFS+LVM+dmcrypt+MD+somethingmore
> setup driving your loved one's life support, you may go ahead.

;-)

How about if I split it into two tiny patches
- one that just makes it no longer a debug option and moves the
option out of the "kernel hacking" submenu and into "general setup"
instead, but leave it to default to N.
- and then one that makes it default Y.
and then submit those two patches to Andrew for inclusion in -mm with
a clear note that only the first one should go upstream anytime soon
and the second one should be kept "strictly -mm" until we arrive at
the point in time where people can no longer break 4K.
How does that sound?
>From my point of view that would accomplish my objective of getting 4K
stacks some more testing and the indication that long-term that's the
way we probably want to move.

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html