From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jan Beulich <jbeulich@novell.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, patches@x86-64.org
Subject: Re: [PATCH] x86: make SMP locks handling interact properly with CONFIG_DEBUG_RODATA (2nd try)
Date: Tue, 17 Jul 2007 10:57:44 -0700 [thread overview]
Message-ID: <469D0318.6060403@goop.org> (raw)
In-Reply-To: <468B5B54.76E4.0078.0@novell.com>
Jan Beulich wrote:
> + if (va < MODULES_VADDR) {
> + change_page_attr(virt_to_page(instr),
> + PFN_UP(va + len) - PFN_DOWN(va),
> +#ifdef CONFIG_X86_64
> + PAGE_KERNEL_RO);
> +#else
> + PAGE_KERNEL_RX);
> +#endif
>
This kind if unbalanced parenthesis can confuse various tools. Format
it differently?
J
next prev parent reply other threads:[~2007-07-17 17:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 6:33 [PATCH] x86: make SMP locks handling interact properly with CONFIG_DEBUG_RODATA (2nd try) Jan Beulich
2007-07-04 15:41 ` Jeremy Fitzhardinge
2007-07-04 16:15 ` Andi Kleen
2007-07-04 16:44 ` Jeremy Fitzhardinge
2007-07-04 16:29 ` Jan Beulich
2007-07-04 17:51 ` Dave Jones
2007-07-04 18:09 ` Jeremy Fitzhardinge
2007-07-17 17:54 ` Andi Kleen
2007-07-17 20:55 ` Mathieu Desnoyers
2007-07-18 6:00 ` Jan Beulich
2007-07-17 17:57 ` Jeremy Fitzhardinge [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-04 16:31 Jan Beulich
2007-07-04 16:46 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469D0318.6060403@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@x86-64.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox