From: Paul Fulghum <paulkf@microgate.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: James Simmons <jsimmons@infradead.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux console project <linuxconsole-dev@lists.sourceforge.net>
Subject: Re: [PATCH] Use tty_schedule in VT code.
Date: Tue, 17 Jul 2007 14:35:28 -0600 [thread overview]
Message-ID: <469D2810.9080109@microgate.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0707171222060.27353@woody.linux-foundation.org>
Linus Torvalds wrote:
>> - schedule_delayed_work(&tty->buf.work, 1);
>> + schedule_delayed_work(&tty->buf.work, 0);
>
> Is there any real reason for this?
>
> I think that patch is bogus. Either it should stay at 1, or the whole work
> should be a non-scheduled one instead.
>
> Do we really need to handle it asap for the console, or is it ok to wait
> for the next tick, like the regular tty case used to?
>
> And if we need to handle it asap, why the "delayed"?
The scheduling is to move the processing out of interrupt context.
The receive data is often extracted from the hardware
at interrupt time and then queued for processing.
--
Paul Fulghum
Microgate Systems, Ltd.
next prev parent reply other threads:[~2007-07-17 20:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 18:37 [PATCH] Use tty_schedule in VT code James Simmons
2007-07-17 18:49 ` Samuel Thibault
2007-07-17 19:17 ` James Simmons
2007-07-17 20:31 ` Paul Fulghum
2007-07-17 19:24 ` Linus Torvalds
2007-07-17 20:35 ` Paul Fulghum [this message]
2007-07-17 19:44 ` Linus Torvalds
2007-07-17 19:52 ` James Simmons
2007-07-17 20:42 ` Linus Torvalds
2007-07-17 23:35 ` Alan Cox
2007-07-18 18:17 ` James Simmons
2007-07-18 18:27 ` Paul Fulghum
2007-07-18 19:57 ` James Simmons
2007-07-18 21:12 ` Paul Fulghum
2007-07-18 20:08 ` Linus Torvalds
2007-07-18 21:36 ` Alan Cox
2007-07-17 21:06 ` Paul Fulghum
2007-07-17 20:15 ` James Simmons
2007-07-17 21:33 ` Paul Fulghum
2007-07-18 17:19 ` James Simmons
-- strict thread matches above, loose matches on Subject: below --
2007-05-08 20:10 James Simmons
2007-05-08 20:32 ` Paul Fulghum
2007-05-09 20:58 ` Paul Fulghum
2007-05-09 20:56 ` James Simmons
2007-05-09 23:02 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469D2810.9080109@microgate.com \
--to=paulkf@microgate.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxconsole-dev@lists.sourceforge.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox