Re: [PATCH] Use tty_schedule in VT code.

Paul Fulghum
2007-07-17T20:30:07Z

Linus Torvalds wrote:
>> - schedule_delayed_work(&tty->buf.work, 1);
>> + schedule_delayed_work(&tty->buf.work, 0);
>
> Is there any real reason for this?
>
> I think that patch is bogus. Either it should stay at 1, or the whole work
> should be a non-scheduled one instead.
>
> Do we really need to handle it asap for the console, or is it ok to wait
> for the next tick, like the regular tty case used to?
>
> And if we need to handle it asap, why the "delayed"?

The scheduling is to move the processing out of interrupt context.
The receive data is often extracted from the hardware
at interrupt time and then queued for processing.

--
Paul Fulghum
Microgate Systems, Ltd.