From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761511AbXGQU3p (ORCPT ); Tue, 17 Jul 2007 16:29:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755964AbXGQU3f (ORCPT ); Tue, 17 Jul 2007 16:29:35 -0400 Received: from adsl-70-250-156-241.dsl.austtx.swbell.net ([70.250.156.241]:50307 "EHLO gw.microgate.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754377AbXGQU3e (ORCPT ); Tue, 17 Jul 2007 16:29:34 -0400 Message-ID: <469D35B1.5050905@microgate.com> Date: Tue, 17 Jul 2007 15:33:37 -0600 From: Paul Fulghum User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: James Simmons CC: Linus Torvalds , Alan Cox , Linux Kernel Mailing List , Linux console project Subject: Re: [PATCH] Use tty_schedule in VT code. References: <469D2810.9080109@microgate.com> <469D2F67.40305@microgate.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org James Simmons wrote: > The low_latency is used by the drivers in the case where its > not in a interrupt context. Well we are trusting the drivers. > Now if it is true what you said then tty_flip_buffer_push has > a bug. Looking at several drivers including serial devices > they set the low_latency flag. The generic serial driver (8250) is the one that was dead locking when that code originally existed. It was setting low_latency and calling from interrupt context. >> And the initial schedule has no reason to add the extra delay. > > So do you support a non delay work queue as well? No, the delay work must be used for flush_to_ldisc() so it makes no sense to define two different work queues (one delayed and one not) for the same work. I support your patch. The current stuff works and your patch works. With your patch, you actually reduce initial latency for processing receive data. Whichever way everyone else wants to go. -- Paul Fulghum Microgate Systems, Ltd.