Re: [PATCH 0/2] SELinux Netlabel updates

[Michal Piotrowski <michal.k.k.piotrowski@gmail.com>]

Linus Torvalds pisze:
> 
> On Tue, 17 Jul 2007, James Morris wrote:
>> These are updated Netlabel/SELinux changes from Paul, reworked so that 
>> they don't break userspace.  Michal says they work for him.  Please apply 
>> for 2.6.23.
> 
> They don't work AT ALL for me:
> 
> 	security/selinux/ss/sidtab.o: In function `netlbl_enabled':
> 	sidtab.c:(.text+0x0): multiple definition of `netlbl_enabled'
> 	security/selinux/ss/ebitmap.o:ebitmap.c:(.text+0x0): first defined here
> 
> Tssk.

Once again I tested both patches, build log shows only this

Root device is (8, 1)
Setup is 10264 bytes (padded to 10752 bytes).
System is 2040 kB
WARNING: vmlinux(.text+0xc1001183): Section mismatch: reference to .init.text:start_kernel (between 'is386' and 'check_x87')
WARNING: vmlinux(.text+0xc126dafb): Section mismatch: reference to .init.text: (between 'rest_init' and 'kthreadd_setup')
WARNING: vmlinux(.text+0xc1271a3b): Section mismatch: reference to .init.text: (between 'iret_exc' and '_etext')
WARNING: vmlinux(.text+0xc1271a48): Section mismatch: reference to .init.text: (between 'iret_exc' and '_etext')
WARNING: vmlinux(.text+0xc1271a54): Section mismatch: reference to .init.text: (between 'iret_exc' and '_etext')
WARNING: vmlinux(.text+0xc1271a60): Section mismatch: reference to .init.text: (between 'iret_exc' and '_etext')
WARNING: vmlinux(.text+0xc126dc11): Section mismatch: reference to .init.text:__alloc_bootmem_node (between 'alloc_node_mem_
map' and 'zone_wait_table_init')
WARNING: vmlinux(.text+0xc126dc9b): Section mismatch: reference to .init.text:__alloc_bootmem_node (between 'zone_wait_table
_init' and '__sched_text_start')
WARNING: vmlinux(.text+0xc1272252): Section mismatch: reference to .init.text: (between 'iret_exc' and '_etext')

gcc --version
gcc (GCC) 4.1.2 20070502 (Red Hat 4.1.2-12)

> 
> That dummy "netlbl_enabled()" should be "static inline", methinks.
> 
> Also, that <net/netlabel.h> file has two blocks after each other of
> 
> 	#ifdef CONFIG_NETLABEL
> 	..
> 	#else
> 	..
> 	#endif
> 
> 	#ifdef CONFIG_NETLABEL
> 	..
> 	#else
> 	..
> 	#endif
> 
> which might as well be cleaned up at the same time (and might have avoided 
> this bug, since then the people involved would have seen the _correct_ 
> example in the first version)
> 
> Please fix up and ask me to pull again. Preferably by actually fixing up 
> the commit itself, so that we don't unnecessarily have revisions that 
> don't even compile and thus potentially screw up git-bisect attempts.
> 
> 			Linus
> 

Regards,
Michal

-- 
LOG
http://www.stardust.webpages.pl/log/