From: "Jan Beulich" <jbeulich@novell.com>
To: "Andi Kleen" <ak@suse.de>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <patches@x86-64.org>
Subject: Re: [PATCH] x86: make SMP locks handling interact properly with CONFIG_DEBUG_RODATA (2nd try)
Date: Wed, 18 Jul 2007 07:00:56 +0100 [thread overview]
Message-ID: <469DC8B8.76E4.0078.0@novell.com> (raw)
In-Reply-To: <200707171954.34541.ak@suse.de>
>> void alternatives_smp_module_del(struct module *mod)
>> {
>> struct smp_alt_module *item;
>> - unsigned long flags;
>>
>> if (smp_alt_once || noreplace_smp)
>> return;
>>
>> - spin_lock_irqsave(&smp_alt, flags);
>> + spin_lock(&smp_alt);
>
>Unrelated change? Why? Should probably be separate patch.
Absolutely not: You can't call change_page_attr(), or more precisely
global_flush_tlb(), with interrupts disabled. And since interrupt disabling
is unneeded here afaics, I simply changed the calls instead of inventing
some ugly workaround.
I'll do the other adjustments you asked for, but it'll be only in about three
weeks from now...
Jan
next prev parent reply other threads:[~2007-07-18 5:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 6:33 [PATCH] x86: make SMP locks handling interact properly with CONFIG_DEBUG_RODATA (2nd try) Jan Beulich
2007-07-04 15:41 ` Jeremy Fitzhardinge
2007-07-04 16:15 ` Andi Kleen
2007-07-04 16:44 ` Jeremy Fitzhardinge
2007-07-04 16:29 ` Jan Beulich
2007-07-04 17:51 ` Dave Jones
2007-07-04 18:09 ` Jeremy Fitzhardinge
2007-07-17 17:54 ` Andi Kleen
2007-07-17 20:55 ` Mathieu Desnoyers
2007-07-18 6:00 ` Jan Beulich [this message]
2007-07-17 17:57 ` Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2007-07-04 16:31 Jan Beulich
2007-07-04 16:46 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469DC8B8.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@x86-64.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox