Re: [kbuild-devel] [PATCH 25/33] kbuild: use POSIX BRE in headers install target

Mike Frysinger
2007-07-21T22:13:39Z

On 7/21/07, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Sat, Jul 21, 2007 at 06:03:00PM -0400, Mike Frysinger wrote:
> > On 7/21/07, Sam Ravnborg <sam@ravnborg.org> wrote:
> > >I would much more prefer this functionality to be integrated into unifdef.
> > >There is no good reason to have two different preprocesisng methonds, one
> > >being the sed based one and the other the unidef one.
> > >
> > >A sinlge dedicated program that contian the sum of the functionality would
> > >be faster too.
> >
> > which functionality ? normalizing of whitespace or all these
> > linux-specific hacks ? unifdef serves one specific function which is
> > stated in its manpage: remove preprocessor conditionals from code.
>
> At present the kernel has a private copy of unidef. So adjusting the
> private copy for the needs of the kernels seems like a god plan.

didnt realize the kernel had integrated it since it didnt at first ...
so yeah, extending it however we see fit should be fine
-mike