From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763444AbXGRKL3 (ORCPT ); Wed, 18 Jul 2007 06:11:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756460AbXGRKLL (ORCPT ); Wed, 18 Jul 2007 06:11:11 -0400 Received: from stinky.trash.net ([213.144.137.162]:34307 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755905AbXGRKLJ (ORCPT ); Wed, 18 Jul 2007 06:11:09 -0400 Message-ID: <469DE724.2020000@trash.net> Date: Wed, 18 Jul 2007 12:10:44 +0200 From: Patrick McHardy User-Agent: Debian Thunderbird 1.0.7 (X11/20051019) X-Accept-Language: en-us, en MIME-Version: 1.0 To: David Miller CC: crquan@gmail.com, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] [net/core] move dev_mc_discard from dev_mcast.c to dev.c References: <20070718.021107.40833440.davem@davemloft.net> <91b13c310707180259v547ba2b3wc901102d35760a50@mail.gmail.com> <469DE502.8070800@trash.net> <20070718.030440.124084796.davem@davemloft.net> In-Reply-To: <20070718.030440.124084796.davem@davemloft.net> X-Enigmail-Version: 0.93.0.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org David Miller wrote: > From: Patrick McHardy > Date: Wed, 18 Jul 2007 12:01:38 +0200 > > >>rae l wrote: >> >>>All in one word, I don't think the single file dev_mcast.c is needed >>>anymore. >> >>Agreed. But dev.c is growing larger and larger, maybe dev_addr.c? >>Or dev_config.c, with some of the other device configuration functions? > > > I don't know, a sizable dev.c is inevitable, allows better refactoring > and consolidation. And the be honest you're going to have to likely > touch things in dev.c whenever you make changes to dev_addr.c or > whatever you want to name it. :-) You're probably right. Killing dev_mcast.c makes sense to me though.