From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932193AbXGRLSn (ORCPT ); Wed, 18 Jul 2007 07:18:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752088AbXGRLSc (ORCPT ); Wed, 18 Jul 2007 07:18:32 -0400 Received: from wa-out-1112.google.com ([209.85.146.179]:3510 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753253AbXGRLSa (ORCPT ); Wed, 18 Jul 2007 07:18:30 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=ZhHRFVPnpSFT9e2RGzlM+lFAR4bzBVVwROnjCegfOMV5mH7jkZoJ6eUy4Kv4WRD9++BdaM1L4Bhnmk740lZRfiuO/m2fyuQDqTjm/T95vItb1L3mXp5XrB9pzuNWlpEL+DolqxXgO+NhyoSjbCXZj0HHjcxK2DhNLc5r466aKXg= Message-ID: <469DF700.4030806@gmail.com> Date: Wed, 18 Jul 2007 20:18:24 +0900 From: Tejun Heo User-Agent: Icedove 1.5.0.10 (X11/20070307) MIME-Version: 1.0 To: Jens Axboe CC: Neil Brown , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, David Chinner , Phillip Susi , Stefan Bader , Andreas Dilger Subject: Re: [PATCH] block: factor out bio_check_eod() References: <18006.38689.818186.221707@notabene.brown> <18010.12472.209452.148229@notabene.brown> <20070530093503.GA15559@kernel.dk> <20070718105655.GB22374@htj.dyndns.org> <20070718105946.GC22374@htj.dyndns.org> <20070718110619.GM11657@kernel.dk> In-Reply-To: <20070718110619.GM11657@kernel.dk> X-Enigmail-Version: 0.94.2.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jens Axboe wrote: > On Wed, Jul 18 2007, Tejun Heo wrote: >> End of device check is done twice in __generic_make_request() and it's >> fully inlined each time. Factor out bio_check_eod(). > > Tejun, yeah I should seperate the cleanups and put them in the upstream > branch. Will do so and add your signed-off to both of them. > Would they be different from the one I just posted? No big deal either way. I'm just basing the zero-length barrier on top of these patches. Oh well, the changes are trivial anyway. -- tejun