Re: [PATCH] sysfs: cosmetic clean up on node creation failure paths

Cornelia Huck
2007-07-18T11:40:42Z

On Wed, 18 Jul 2007 16:38:11 +0900,
Tejun Heo <htejun@gmail.com> wrote:

> Node addition failure is detected by testing return value of
> sysfs_addfm_finish() which returns the number of added and removed
> nodes. As the function is called as the last step of addition right
> on top of error handling block, the if blocks looked like the
> following.
>
> if (sysfs_addrm_finish(&acxt))
> success handling, usually return;
> /* fall through to error handling */
>
> This is the opposite of usual convention in sysfs and makes the code
> difficult to understand. This patch inverts the test and makes those
> blocks look more like others.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> fs/sysfs/dir.c | 12 +++++++-----
> fs/sysfs/file.c | 9 +++++----
> fs/sysfs/symlink.c | 10 ++++++----
> 3 files changed, 18 insertions(+), 13 deletions(-)

Looks nice. One thing, though:

sysfs_hash_and_remove() has the same check, but without a cleanup
section. This should follow the (!sysfs_addrm_finish()) pattern as well
(makes pattern matching easier when reading the code).