Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

Tejun Heo
2007-07-18T16:20:59Z

Satyam Sharma wrote:
>> On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
>> > Satyam Sharma wrote:
>> > > On 7/18/07, Tejun Heo <htejun@gmail.com> wrote:
>> > >> There is a subtle bug in sysfs_create_link() failure path. When
>> > >> symlink creation fails because there's already a node with the same
>> > >> name, the target sysfs_dirent is put twice - once by failure path of
>> > >> sysfs_create_link() and once more when the symlink is released.
>> > >
>> > > The "symlink" is released? But the creation of the symlink is
>> > > precisely what failed here ... did it not?
>> > >
>> > >> Fix it by making only the symlink node responsible for putting
>> > >> target_sd.
>> > >
>> > > And again ... the changelog sounds confusing indeed, perhaps I'm
>> > > not familiar enough with sysfs symlink-related terminology/semantics.
>> > > Care to elaborate?
>
> BTW, please do explain this one to me, if you can find the time :-)

A symlink node holds two sd's. Its parent as all other sd nodes and the
sd the symlink point to. When the symlink is released (its refcnt goes
to zero), it puts both. In this bug, the symlink is released twice -
once in the error handling path and one more time when symlink is released.

--
tejun