public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dor Laor <dor.laor@qumranet.com>,
	kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] [RFC] Deferred interrupt handling.
Date: Wed, 18 Jul 2007 19:46:13 +0300	[thread overview]
Message-ID: <469E43D5.70802@qumranet.com> (raw)
In-Reply-To: <20070718174736.0baf6d0e@the-village.bc.nu>

Alan Cox wrote:
>> What if we will force the specific device to the end of the list. Once
>> IRQ_NONE was returned by the other devices, we will mask the irq,
>> forward the irq to the guest, issue a timer for 1msec. Motivation:
>> 1msec is long enough for the guest to ack the irq + host unmask the irq
>>     
>
> It makes no difference. The deadlock isn't fixable by timing hacks.
> Consider the following sequence
>
>
> 	Guest0	-	blocked on I/O
>
> 	IRQ14 from your hardware
> 		Block IRQ14
> 		Sent to guest (guest is blocked)
>
> 	IRQ14 from hard disk
> 		Ignored (as blocked)
>
> 	Deadlock
>   

IMO the only reasonable solution is to disallow interrupt forwarding
with shared irqs.  If someone later comes up with a bright idea, we can
implement it.  Otherwise the problem will solve itself with hardware
moving to msi.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


  reply	other threads:[~2007-07-18 16:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-18  9:53 [RFC] Deferred interrupt handling Or Sagi
2007-07-18 11:30 ` Alan Cox
2007-07-18 16:36   ` [kvm-devel] " Dor Laor
2007-07-18 16:47     ` Alan Cox
2007-07-18 16:46       ` Avi Kivity [this message]
2007-07-18 16:57         ` Alan Cox
2007-07-18 16:57           ` Avi Kivity
2007-07-18 17:14             ` Alan Cox
2007-07-18 17:09         ` Dor Laor
2007-07-18 17:33           ` Alan Cox
2007-07-18 21:29             ` Dor Laor
2007-07-18 21:46               ` Alan Cox
2007-07-25 14:18                 ` Pavel Machek
2007-07-18 22:23               ` Or Sagi
2007-07-18 19:14         ` Lennart Sorensen
2007-07-19  9:23           ` Avi Kivity
2007-07-19 13:17             ` Lennart Sorensen
2007-07-19 13:38               ` Avi Kivity
2007-07-19 16:23                 ` Lennart Sorensen
2007-07-18 15:57 ` Lennart Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469E43D5.70802@qumranet.com \
    --to=avi@qumranet.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dor.laor@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox