Re: [PATCH][RFC] Delete export of tty.h to userspace.

[Jiri Slaby <jirislaby@gmail.com>]

Robert P. J. Day napsal(a):
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 
> ---
> 
>   given that the entire contents of include/linux/tty.h is contained
> within an "#ifdef __KERNEL__", it seems pointless to export it to
> userspace, unless there's some kind of need for that header file to
> exist in userspace, even if it's empty.
> 
>   a quick grep shows that nothing under /usr/include references any
> file of the name "tty.h" in any way.  thoughts?

If we decide to remove the file, I would rather go through deprecation of the
file with filing an entry in feature-remove-schedule. There still seems to be
some users of the file.

With deprecation done with sth. like
#ifndef __KERNEL__
#warning Don't include this file from userspace, it's emtpy.
#endif

>  diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index 4ff0f57..63de91a 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -328,7 +327,6 @@ unifdef-y += sysctl.h
>  unifdef-y += tcp.h
>  unifdef-y += time.h
>  unifdef-y += timex.h
> -unifdef-y += tty.h
>  unifdef-y += types.h
>  unifdef-y += udf_fs_i.h
>  unifdef-y += udp.h


-- 
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University