Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

Robert P. J. Day
2007-09-01T10:57:20Z

On Fri, 31 Aug 2007, Randy Dunlap wrote:

> On Thu, 19 Jul 2007 23:05:57 +0100 Simon Arlott wrote:

> > What about something like this? I'm not sure if the addition to
> > sym_init is desirable... I also had to prefix _ to the name for
> > now otherwise it conflicts badly with the current symbols. It
> > probably should stop "depends on _BROKEN" etc. too.
>
> Hi Simon,
>
> (sorry for the delay)
>
> I like this patch very much... I just can't get it to build (on
> 2.6.23-rc4).

i got a patch from simon a while back, and it failed with
"shift/reduce" conflicts. is that what you're seeing?

> > while (1) {
> > printf("%*s%s ", indent - 1, "", menu->prompt->text);
> > + switch (sym->maturity) {
> > + case M_EXPERIMENTAL:
> > + printf("(EXPERIMENTAL) ");
> > + break;
> > + case M_DEPRECATED:
> > + printf("(DEPRECATED) ");
> > + break;
> > + case M_OBSOLETE:
> > + printf("(OBSOLETE) ");
> > + break;
> > + case M_BROKEN:
> > + printf("(BROKEN) ");
> > + break;
> > + default:
> > + break;
> > + }
> > if (sym->name)
> > printf("(%s) ", sym->name);
> > type = sym_get_type(sym);

for now, simon, why not just reduce this to supporting only DEPRECATED
and OBSOLETE so that it can be at least tested as "proof of concept?"

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================