From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762051AbXGSGlT (ORCPT ); Thu, 19 Jul 2007 02:41:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754699AbXGSGlJ (ORCPT ); Thu, 19 Jul 2007 02:41:09 -0400 Received: from orion2.pixelized.ch ([195.190.190.13]:42874 "EHLO mail.pixelized.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754495AbXGSGlI (ORCPT ); Thu, 19 Jul 2007 02:41:08 -0400 Message-ID: <469F0770.2090309@cateee.net> Date: Thu, 19 Jul 2007 08:40:48 +0200 From: Giacomo Catenazzi User-Agent: Mozilla-Thunderbird 2.0.0.4 (X11/20070622) MIME-Version: 1.0 To: Linus Torvalds CC: Bartlomiej Zolnierkiewicz , Jens Axboe , Linux Kernel Mailing List , akpm@linux-foundation.org Subject: Re: regression: disk error loop (panic?) ide_do_rw_disk-bad: References: <469D1D5E.8050609@cateee.net> <20070718202740.GN11657@kernel.dk> <200707190053.24578.bzolnier@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > > On Thu, 19 Jul 2007, Bartlomiej Zolnierkiewicz wrote: >> Thanks for finding and fixing this. >> >> The latest patch (with additional cleanups) also looks good and should be >> safe enough (unchanged behavior for all non-pc requests) to merge it now. >> >> Acked-by: Bartlomiej Zolnierkiewicz > > Ok, Jens - mind signing off on the patch you sent out, and writing an > explanatory message? Feel free to just crib from my explanation of my > original patch, or whatever. > > And it would be beautiful if people who saw the bad behaviour before > reverting the ide.c changes were to go back to that broken state, and try > the patch, and just verify that it acts like it should (ie you should see > just a few error messages, and it shouldn't cause the IDE layer to go > ballistic any more). Ok, I tested a5fcaa210626a79465321e344c91a6a7dc3881fa , with the Jeans' patch with clean-up (Message-ID: <20070718201152.GL11657@kernel.dk>). I don't see the error loop. but only 4 errors (2 for each hd, at hddtemp start) Jul 19 08:22:19 catee kernel: hda: selected mode 0x45 Jul 19 08:22:23 catee kernel: ide_do_rw_disk - bad command: dev hda: type=2, flags=104c8 Jul 19 08:22:23 catee kernel: Jul 19 08:22:23 catee kernel: sector 14657019, nr/cnr 0/0 Jul 19 08:22:23 catee kernel: bio c21a4780, biotail c21a4780, buffer 00000000, data 00000000, len 36 Jul 19 08:22:23 catee kernel: cdb: 12 00 00 00 24 00 00 00 00 00 00 00 00 00 00 00 Jul 19 08:22:23 catee kernel: ide_do_rw_disk - bad command: dev hdc: type=2, flags=104c8 Jul 19 08:22:23 catee kernel: Jul 19 08:22:23 catee kernel: sector 34711027, nr/cnr 0/0 Jul 19 08:22:23 catee kernel: bio c21a4740, biotail c21a4740, buffer 00000000, data 00000000, len 36 Jul 19 08:22:23 catee kernel: cdb: 12 00 00 00 24 00 00 00 00 00 00 00 00 00 00 00 Jul 19 08:22:23 catee kernel: ide_do_rw_disk - bad command: dev hdc: type=2, flags=104c8 Jul 19 08:22:23 catee kernel: Jul 19 08:22:23 catee kernel: sector 7387152, nr/cnr 0/0 Jul 19 08:22:23 catee kernel: bio c21a4900, biotail c21a4900, buffer 00000000, data 00000000, len 36 Jul 19 08:22:23 catee kernel: cdb: 12 00 00 00 24 00 00 00 00 00 00 00 00 00 00 00 Jul 19 08:22:23 catee kernel: ide_do_rw_disk - bad command: dev hda: type=2, flags=104c8 Jul 19 08:22:23 catee kernel: Jul 19 08:22:23 catee kernel: sector 7387152, nr/cnr 0/0 Jul 19 08:22:23 catee kernel: bio c21a4900, biotail c21a4900, buffer 00000000, data 00000000, len 36 Jul 19 08:22:23 catee kernel: cdb: 12 00 00 00 24 00 00 00 00 00 00 00 00 00 00 00 Jul 19 08:22:27 catee kernel: ttyS1: LSR safety check engaged! The last git tree give me no errors. patch in Message-ID: <20070718201152.GL11657@kernel.dk> Tested-By: Giacomo Catenazzi ciao cate