From: Jiri Slaby <jirislaby@gmail.com>
To: Christoph Hellwig <hch@infradead.org>,
"Robert P. J. Day" <rpjday@mindspring.com>,
Karel Zak <kzak@redhat.com>, Jiri Slaby <jirislaby@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH][RFC] Delete export of tty.h to userspace.
Date: Thu, 19 Jul 2007 17:32:39 +0200 [thread overview]
Message-ID: <469F8417.5020008@gmail.com> (raw)
In-Reply-To: <20070719135707.GA16279@infradead.org>
Christoph Hellwig napsal(a):
> On Thu, Jul 19, 2007 at 07:17:07AM -0400, Robert P. J. Day wrote:
>> so you're saying you'll drop that include from util-linux, is that it?
>> but it's still a good plan to generate a warning whenever userspace
>> includes that file, so i'll submit a quick patch to generate that,
>> based on jiri's suggestion.
>
> Not exporting it at all gives an error which is a lot better. Just look
> at all the warnings most userspace spews, they'd never even notice it
> otherwise.
Not directly responding to this, but keeping CCs. I though of the removal one
more time and there is one more issue (maybe). Every exported kernel header,
which includes this file outside #ifdef __KERNEL__ #endif will be broken in
userspace. Are you sure, there are no such includes?
--
Jiri Slaby (jirislaby@gmail.com)
Faculty of Informatics, Masaryk University
next prev parent reply other threads:[~2007-07-19 15:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 9:24 [PATCH][RFC] Delete export of tty.h to userspace Robert P. J. Day
2007-07-18 20:18 ` Jiri Slaby
2007-07-18 20:33 ` Robert P. J. Day
2007-07-18 22:38 ` Karel Zak
2007-07-19 11:17 ` Robert P. J. Day
2007-07-19 13:57 ` Christoph Hellwig
2007-07-19 15:27 ` Robert P. J. Day
2007-07-19 15:32 ` Jiri Slaby [this message]
2007-07-19 16:10 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469F8417.5020008@gmail.com \
--to=jirislaby@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hch@infradead.org \
--cc=kzak@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox