From: Simon Arlott <simon@fire.lp0.eu>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Denis Cheng <crquan@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle
Date: Fri, 20 Jul 2007 18:36:02 +0100 [thread overview]
Message-ID: <46A0F282.8070103@simon.arlott.org.uk> (raw)
In-Reply-To: <20070720170743.GF14791@parisc-linux.org>
On 20/07/07 18:07, Matthew Wilcox wrote:
> Of course, we can't add this flag to Lindent until it's widely
> circulating amongst the distributions. Perhaps we can add this to
> Lindent in the meantime:
>
> sed -i -e 's/^\t* \(\w*:\)/ \1/' "$@"
>
> which will replace the leading tabs and spaces with one space.
> It should leave case labels unmolested, as they should be indented with
> tabs, not 6 spaces.
... isn't the space thing a workaround for a "diff -p" bug?
Labels should either not have any indent or be indented by tabs (since
some code could presumably benefit from indenting labels). Mass
replacing any labels run through Lindent with space prefixes would seem
like a bad idea :/
(From original reply)
It has a habit of leaving/creating "^\t+ +" too, and that "\t\t/*
comment */$" oddity, I couldn't see any options in the man page to fix
those...
--
Simon Arlott
next prev parent reply other threads:[~2007-07-20 17:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 8:52 [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Denis Cheng
2007-07-15 8:52 ` [PATCH 2/2] add static delaration and init_module fixes Denis Cheng
2007-07-15 9:20 ` [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Christoph Hellwig
2007-07-15 9:53 ` Simon Arlott
2007-07-20 17:07 ` Matthew Wilcox
2007-07-20 17:36 ` Simon Arlott [this message]
2007-07-20 18:00 ` Matthew Wilcox
2007-07-21 6:11 ` Simon Arlott
2007-07-21 13:47 ` rae l
2007-07-21 13:52 ` Matthew Wilcox
2007-07-21 19:17 ` diffutils: C labels misdetected as functions (Was: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle) Simon Arlott
2007-07-22 18:38 ` diffutils: C labels misdetected as functions Paul Eggert
2007-07-22 19:16 ` Simon Arlott
2007-07-22 21:30 ` Junio C Hamano
2007-07-21 6:12 ` [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Simon Arlott
2007-07-20 20:50 ` Oleg Verych
2007-07-20 20:54 ` Matthew Wilcox
2007-07-21 4:32 ` Fixing lables after GNU indent (Re: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle) Oleg Verych
2007-07-21 16:17 ` [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle Jan Engelhardt
2007-07-20 17:33 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A0F282.8070103@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=crquan@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox