From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932274AbXGUUTS (ORCPT ); Sat, 21 Jul 2007 16:19:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761792AbXGUUTI (ORCPT ); Sat, 21 Jul 2007 16:19:08 -0400 Received: from terminus.zytor.com ([198.137.202.10]:46407 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761113AbXGUUTG (ORCPT ); Sat, 21 Jul 2007 16:19:06 -0400 Message-ID: <46A26A2E.7070305@zytor.com> Date: Sat, 21 Jul 2007 13:18:54 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.0 (X11/20070419) MIME-Version: 1.0 To: Muli Ben-Yehuda CC: Andi Kleen , Glauber de Oliveira Costa , Linux Kernel Mailing List Subject: Re: [PATCH] x86: Create clflush() inline, remove hardcoded wbinvd References: <1184885740.16311.19.camel@t60> <200707202119.l6KLJwcd004205@tazenda.hos.anvin.org> <20070721181137.GH4152@rhun.haifa.ibm.com> <46A263FA.70501@zytor.com> <20070721201634.GF1193@rhun.ibm.com> In-Reply-To: <20070721201634.GF1193@rhun.ibm.com> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Muli Ben-Yehuda wrote: > > So it looks like we have a purely syntactic patch that does something > different than the original code in one of the above places. What am I > missing? > +static inline void clflush(volatile void *__p) +{ + asm volatile("clflush %0" : "+m" (*(char __force *)__p)); ^ +}