From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936130AbXGWVEI (ORCPT ); Mon, 23 Jul 2007 17:04:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763279AbXGWVDw (ORCPT ); Mon, 23 Jul 2007 17:03:52 -0400 Received: from mx1.redhat.com ([66.187.233.31]:46706 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758168AbXGWVDv (ORCPT ); Mon, 23 Jul 2007 17:03:51 -0400 Message-ID: <46A5163D.803@redhat.com> Date: Mon, 23 Jul 2007 15:57:33 -0500 From: Eric Sandeen User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: ext4 development CC: Linux Kernel Mailing List Subject: Re: [PATCH] fix inode_table test in ext234_check_descriptors References: <46A4E254.3010606@redhat.com> In-Reply-To: <46A4E254.3010606@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Eric Sandeen wrote: > ext[234]_check_descriptors sanity checks block group descriptor geometry > at mount time, testing whether the block bitmap, inode bitmap, and > inode table reside wholly within the blockgroup. However, the inode > table test is off by one so that if the last block in the inode table > resides on the last block of the block group, the test incorrectly > fails. This is because it tests the last block as (start + length) > rather than (start + length - 1). > > This can be seen by trying to mount a filesystem made such as: > mkfs.ext2 -F -b 1024 -m 0 -g 256 -N 3744 fsfile 1024 > which yields: > EXT2-fs error (device loop0): ext2_check_descriptors: Inode table for group 0 not in group (block 101)! > EXT2-fs: group descriptors corrupted! Hm, sorry, after seeing Miklos' last patches... should I be sending these as 3 different patches for ext2, 3, and 4...? -Eric (who really doesn't want to make Andrew mad at him) :)