From: Avi Kivity <avi@qumranet.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [RFC 7/8]KVM: swap out guest pages
Date: Tue, 24 Jul 2007 08:38:51 +0300 [thread overview]
Message-ID: <46A5906B.6080301@qumranet.com> (raw)
In-Reply-To: <1185241908.24201.22.camel@sli10-conroe.sh.intel.com>
Shaohua Li wrote:
>>>
>>>
>> You're not removing any shadows of the page, in case that page is a
>> guest page table. But I don't see anything wrong with it -- the page
>> won't change while it's in swap.
>>
> You are right. Should we?
>
I don't think so. It's just strange to have shadows for a guest page
that is swapped out, so I pointed that out. But as the page cannot
change in swap, everything is safe. I guess that kernel page tables
could be swapped out after a short while in a guest that doesn't swap
its own kernel pages.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2007-07-24 5:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 6:51 [RFC 7/8]KVM: swap out guest pages Shaohua Li
2007-07-23 11:32 ` Avi Kivity
2007-07-24 1:51 ` Shaohua Li
2007-07-24 5:38 ` Avi Kivity [this message]
2007-07-24 14:55 ` Avi Kivity
2007-07-25 11:55 ` [kvm-devel] " Shaohua Li
2007-07-25 13:20 ` Shaohua Li
2007-07-25 13:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A5906B.6080301@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox