public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Adrian Bunk <bunk@stusta.de>,
	lksctp-developers@lists.sourceforge.net,
	Gabriel C <nix.or.die@googlemail.com>,
	"Nelson, Shannon" <shannon.nelson@intel.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Lksctp-developers] __unsafe() usage
Date: Tue, 24 Jul 2007 09:05:31 -0400	[thread overview]
Message-ID: <46A5F91B.50403@hp.com> (raw)
In-Reply-To: <1185232601.1803.41.camel@localhost.localdomain>

Rusty Russell wrote:
>  
[... snip ...]

> diff -r d7af727512fd net/sctp/protocol.c
> --- a/net/sctp/protocol.c	Tue Jul 24 08:30:05 2007 +1000
> +++ b/net/sctp/protocol.c	Tue Jul 24 09:12:43 2007 +1000
> @@ -1176,7 +1176,6 @@ SCTP_STATIC __init int sctp_init(void)
>  	if (status)
>  		goto err_v6_add_protocol;
>  
> -	__unsafe(THIS_MODULE);
>  	status = 0;
>  out:
>  	return status;
> @@ -1216,6 +1215,7 @@ err_chunk_cachep:
>  	goto out;
>  }
>  
> +#if 0
>  /* Exit handler for the SCTP protocol.  */
>  SCTP_STATIC __exit void sctp_exit(void)
>  {
> @@ -1263,9 +1263,10 @@ SCTP_STATIC __exit void sctp_exit(void)
>  
>  	proto_unregister(&sctp_prot);
>  }
> +module_exit(sctp_exit);
> +#endif
>  
>  module_init(sctp_init);
> -module_exit(sctp_exit);
>  

Please don't remove module_exit point for SCTP.  Simply removing the __unsafe() call will
be sufficient.

The code has recently been cleaned up to allow safe unloading and I working on final
cleanups.  It currently works correctly with forced unloading.

Thanks

-vlad


  parent reply	other threads:[~2007-07-24 13:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <46A3FE3E.20300@googlemail.com>
2007-07-23  1:15 ` drivers/dma/ioatdma.c - address of '__this_module' will always evaluate as 'true' , warning Gabriel C
2007-07-23 16:05 ` Nelson, Shannon
2007-07-23 16:36   ` Gabriel C
2007-07-23 19:17     ` Nelson, Shannon
2007-07-23 17:59   ` __unsafe() usage Adrian Bunk
2007-07-23 23:16     ` Rusty Russell
2007-07-23 23:40       ` Nelson, Shannon
2007-07-23 23:42       ` Dan Williams
2007-07-24 13:05       ` Vlad Yasevich [this message]
2007-07-24 22:27         ` [Lksctp-developers] " Rusty Russell
2007-07-25 14:55           ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A5F91B.50403@hp.com \
    --to=vladislav.yasevich@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lksctp-developers@lists.sourceforge.net \
    --cc=nix.or.die@googlemail.com \
    --cc=rusty@rustcorp.com.au \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox